runtime/vm/intermediate_language_ia32.cc - Issue 157833004: Disable hoisting CheckClass due to excessive deoptimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 157833004: Disable hoisting CheckClass due to excessive deoptimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 32457)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -4518,9 +4518,10 @@

void CheckClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

+ const DeoptReasonId deopt_reason =

+ licm_hoisted_ ? kDeoptHoistedCheckClass : kDeoptCheckClass;

if (IsNullCheck()) {

- Label* deopt = compiler->AddDeoptStub(deopt_id(),

- kDeoptCheckClass);

+ Label* deopt = compiler->AddDeoptStub(deopt_id(), deopt_reason);

const Immediate& raw_null =

Immediate(reinterpret_cast<intptr_t>(Object::null()));

__ cmpl(locs()->in(0).reg(), raw_null);

@@ -4532,8 +4533,7 @@

(unary_checks().NumberOfChecks() > 1));

- Label* deopt = compiler->AddDeoptStub(deopt_id(),

- kDeoptCheckClass);

+ Label* deopt = compiler->AddDeoptStub(deopt_id(), deopt_reason);

Label is_ok;

intptr_t cix = 0;

if (unary_checks().GetReceiverClassIdAt(cix) == kSmiCid) {

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »