Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: runtime/vm/intermediate_language.cc

Issue 157833004: Disable hoisting CheckClass due to excessive deoptimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/intermediate_language.h" 5 #include "vm/intermediate_language.h"
6 6
7 #include "vm/bigint_operations.h" 7 #include "vm/bigint_operations.h"
8 #include "vm/bit_vector.h" 8 #include "vm/bit_vector.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flow_graph_allocator.h" 10 #include "vm/flow_graph_allocator.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 78
79 79
80 bool Value::Equals(Value* other) const { 80 bool Value::Equals(Value* other) const {
81 return definition() == other->definition(); 81 return definition() == other->definition();
82 } 82 }
83 83
84 84
85 CheckClassInstr::CheckClassInstr(Value* value, 85 CheckClassInstr::CheckClassInstr(Value* value,
86 intptr_t deopt_id, 86 intptr_t deopt_id,
87 const ICData& unary_checks) 87 const ICData& unary_checks)
88 : unary_checks_(unary_checks) { 88 : unary_checks_(unary_checks), licm_hoisted_(false) {
89 ASSERT(unary_checks.IsZoneHandle()); 89 ASSERT(unary_checks.IsZoneHandle());
90 // Expected useful check data. 90 // Expected useful check data.
91 ASSERT(!unary_checks_.IsNull()); 91 ASSERT(!unary_checks_.IsNull());
92 ASSERT(unary_checks_.NumberOfChecks() > 0); 92 ASSERT(unary_checks_.NumberOfChecks() > 0);
93 ASSERT(unary_checks_.num_args_tested() == 1); 93 ASSERT(unary_checks_.num_args_tested() == 1);
94 SetInputAt(0, value); 94 SetInputAt(0, value);
95 deopt_id_ = deopt_id; 95 deopt_id_ = deopt_id;
96 // Otherwise use CheckSmiInstr. 96 // Otherwise use CheckSmiInstr.
97 ASSERT((unary_checks_.NumberOfChecks() != 1) || 97 ASSERT((unary_checks_.NumberOfChecks() != 1) ||
98 (unary_checks_.GetReceiverClassIdAt(0) != kSmiCid)); 98 (unary_checks_.GetReceiverClassIdAt(0) != kSmiCid));
(...skipping 3045 matching lines...) Expand 10 before | Expand all | Expand 10 after
3144 case Token::kTRUNCDIV: return 0; 3144 case Token::kTRUNCDIV: return 0;
3145 case Token::kMOD: return 1; 3145 case Token::kMOD: return 1;
3146 default: UNIMPLEMENTED(); return -1; 3146 default: UNIMPLEMENTED(); return -1;
3147 } 3147 }
3148 } 3148 }
3149 3149
3150 3150
3151 #undef __ 3151 #undef __
3152 3152
3153 } // namespace dart 3153 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698