Add chromeos-specific packages to linux sysroot image

Add chromeos-specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
Committed: https://crrev.com/82063a2b94fb4f727841cf6a8f67740f990658fb
Cr-Commit-Position: refs/heads/master@{#368977}

[Sam Clegg, 2016-01-12 19:01:21]

Description was changed from

==========
Add chromeos specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
==========

to

==========
Add chromeos specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
==========

[Sam Clegg, 2016-01-12 19:01:21]

sbc@chromium.org changed reviewers:
+ thestig@chromium.org

[Sam Clegg, 2016-01-12 19:01:32]

Description was changed from

==========
Add chromeos specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
==========

to

==========
Add chromeos-specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
==========

[Nico, 2016-01-12 19:29:49]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-01-12 19:29:49]

huh, that's all? that can't possibly big, lgtm :-)

[Sam Clegg, 2016-01-12 19:31:01]

On 2016/01/12 19:29:49, Nico wrote:
> huh, that's all? that can't possibly big, lgtm :-)

My guess is it already contains a few packages which are chromeos only.

[Sam Clegg, 2016-01-12 19:31:06]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2016-01-12 19:31:58]

On 2016/01/12 19:31:01, Sam Clegg wrote:
> On 2016/01/12 19:29:49, Nico wrote:
> > huh, that's all? that can't possibly big, lgtm :-)
> 
> My guess is it already contains a few packages which are chromeos only.

Also, I couldn't find a GN equivalent for "chromeos=1".. assuming that mode not
supported in GN yet?

[commit-bot: I haz the power, 2016-01-12 19:33:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578313002/1

[Nico, 2016-01-12 19:33:39]

On 2016/01/12 19:31:58, Sam Clegg wrote:
> On 2016/01/12 19:31:01, Sam Clegg wrote:
> > On 2016/01/12 19:29:49, Nico wrote:
> > > huh, that's all? that can't possibly big, lgtm :-)
> > 
> > My guess is it already contains a few packages which are chromeos only.
> 
> Also, I couldn't find a GN equivalent for "chromeos=1".. assuming that mode
not
> supported in GN yet?

is_chromeos I think

[Sam Clegg, 2016-01-12 19:35:21]

On 2016/01/12 19:33:39, Nico wrote:
> On 2016/01/12 19:31:58, Sam Clegg wrote:
> > On 2016/01/12 19:31:01, Sam Clegg wrote:
> > > On 2016/01/12 19:29:49, Nico wrote:
> > > > huh, that's all? that can't possibly big, lgtm :-)
> > > 
> > > My guess is it already contains a few packages which are chromeos only.
> > 
> > Also, I couldn't find a GN equivalent for "chromeos=1".. assuming that mode
> not
> > supported in GN yet?
> 
> is_chromeos I think

Not yet it seems:

$ gn args out_gn/release/
Waiting for editor on
"/usr/local/google/home/sbc/dev/chromium/src/out_gn/release/args.gn"...
Generating files...
ERROR at build arg file (use "gn args <out_dir>" to edit):6:15: Build argument
has no effect.
is_chromeos = true
              ^---
The variable "is_chromeos" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

[Nico, 2016-01-12 19:37:32]

On 2016/01/12 19:35:21, Sam Clegg wrote:
> On 2016/01/12 19:33:39, Nico wrote:
> > On 2016/01/12 19:31:58, Sam Clegg wrote:
> > > On 2016/01/12 19:31:01, Sam Clegg wrote:
> > > > On 2016/01/12 19:29:49, Nico wrote:
> > > > > huh, that's all? that can't possibly big, lgtm :-)
> > > > 
> > > > My guess is it already contains a few packages which are chromeos only.
> > > 
> > > Also, I couldn't find a GN equivalent for "chromeos=1".. assuming that
mode
> > not
> > > supported in GN yet?
> > 
> > is_chromeos I think
> 
> Not yet it seems:
> 
> $ gn args out_gn/release/
> Waiting for editor on
> "/usr/local/google/home/sbc/dev/chromium/src/out_gn/release/args.gn"...
> Generating files...
> ERROR at build arg file (use "gn args <out_dir>" to edit):6:15: Build argument
> has no effect.
> is_chromeos = true
>               ^---
> The variable "is_chromeos" was set as a build argument
> but never appeared in a declare_args() block in any buildfile.

I think that's how you check for it -- if you want to set it I think you have to
say

target_os = "chromeos"

See here:
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...

[Sam Clegg, 2016-01-12 19:42:57]

On 2016/01/12 19:37:32, Nico wrote:
> On 2016/01/12 19:35:21, Sam Clegg wrote:
> > On 2016/01/12 19:33:39, Nico wrote:
> > > On 2016/01/12 19:31:58, Sam Clegg wrote:
> > > > On 2016/01/12 19:31:01, Sam Clegg wrote:
> > > > > On 2016/01/12 19:29:49, Nico wrote:
> > > > > > huh, that's all? that can't possibly big, lgtm :-)
> > > > > 
> > > > > My guess is it already contains a few packages which are chromeos
only.
> > > > 
> > > > Also, I couldn't find a GN equivalent for "chromeos=1".. assuming that
> mode
> > > not
> > > > supported in GN yet?
> > > 
> > > is_chromeos I think
> > 
> > Not yet it seems:
> > 
> > $ gn args out_gn/release/
> > Waiting for editor on
> > "/usr/local/google/home/sbc/dev/chromium/src/out_gn/release/args.gn"...
> > Generating files...
> > ERROR at build arg file (use "gn args <out_dir>" to edit):6:15: Build
argument
> > has no effect.
> > is_chromeos = true
> >               ^---
> > The variable "is_chromeos" was set as a build argument
> > but never appeared in a declare_args() block in any buildfile.
> 
> I think that's how you check for it -- if you want to set it I think you have
to
> say
> 
> target_os = "chromeos"
> 
> See here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...

I thought there was a "OS=linux chromeos=1" mode that was different from
"OS=chromeos chromeos=1"?   I'll try setting target_os in GN.

[Nico, 2016-01-12 19:44:30]

On 2016/01/12 19:42:57, Sam Clegg wrote:
> On 2016/01/12 19:37:32, Nico wrote:
> > On 2016/01/12 19:35:21, Sam Clegg wrote:
> > > On 2016/01/12 19:33:39, Nico wrote:
> > > > On 2016/01/12 19:31:58, Sam Clegg wrote:
> > > > > On 2016/01/12 19:31:01, Sam Clegg wrote:
> > > > > > On 2016/01/12 19:29:49, Nico wrote:
> > > > > > > huh, that's all? that can't possibly big, lgtm :-)
> > > > > > 
> > > > > > My guess is it already contains a few packages which are chromeos
> only.
> > > > > 
> > > > > Also, I couldn't find a GN equivalent for "chromeos=1".. assuming that
> > mode
> > > > not
> > > > > supported in GN yet?
> > > > 
> > > > is_chromeos I think
> > > 
> > > Not yet it seems:
> > > 
> > > $ gn args out_gn/release/
> > > Waiting for editor on
> > > "/usr/local/google/home/sbc/dev/chromium/src/out_gn/release/args.gn"...
> > > Generating files...
> > > ERROR at build arg file (use "gn args <out_dir>" to edit):6:15: Build
> argument
> > > has no effect.
> > > is_chromeos = true
> > >               ^---
> > > The variable "is_chromeos" was set as a build argument
> > > but never appeared in a declare_args() block in any buildfile.
> > 
> > I think that's how you check for it -- if you want to set it I think you
have
> to
> > say
> > 
> > target_os = "chromeos"
> > 
> > See here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...
> 
> I thought there was a "OS=linux chromeos=1" mode that was different from
> "OS=chromeos chromeos=1"?   I'll try setting target_os in GN.

There's OS=linux chromeos=1. I don't think we have OS=chromeos in the gyp build
-- the "real" chromeos build just sets the sysroot GYP_DEFINE to point
somewhere, and it injects a bunch of cflags manually.

(But the real chromeos build also doesn't use gn yet -- I think OS=chromeos is
gn's spelling of gyp's OS=linux chromeos=1 mode)

[Nico, 2016-01-12 19:45:11]

target_os=chromeos is gn's spelling, that is.

It kind of makes sense too: The host os defaults to the host os in gyp, and the
host os is linux in that case.

[commit-bot: I haz the power, 2016-01-12 20:38:51]

Description was changed from

==========
Add chromeos-specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
==========

to

==========
Add chromeos-specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
==========

[commit-bot: I haz the power, 2016-01-12 20:38:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-12 20:40:11]

Description was changed from

==========
Add chromeos-specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807
==========

to

==========
Add chromeos-specific packages to linux sysroot image

This will allow the chromeos=1 build to work against
the wheezy sysroot

BUG=576807

Committed: https://crrev.com/82063a2b94fb4f727841cf6a8f67740f990658fb
Cr-Commit-Position: refs/heads/master@{#368977}
==========

[commit-bot: I haz the power, 2016-01-12 20:40:12]

Patchset 1 (id:??) landed as
https://crrev.com/82063a2b94fb4f727841cf6a8f67740f990658fb
Cr-Commit-Position: refs/heads/master@{#368977}