Issue 1578293003: Fullscreen bubble: Now speaks the bubble text if a11y enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1578293003: Fullscreen bubble: Now speaks the bubble text if a11y enabled. (Closed)

Created:
4 years, 11 months ago by Matt Giuca

Modified:
3 years, 4 months ago

Reviewers:

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fullscreen bubble: Now speaks the bubble text if a11y enabled. DO NOT SUBMIT; THIS IS BROKEN. BUG=577011

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	chrome/browser/ui/views/exclusive_access_bubble_views.cc	View	1	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/subtle_notification_view.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/subtle_notification_view.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/views/accessibility/ax_view_obj_wrapper.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Matt Giuca

3 years, 4 months ago (2017-08-22 03:18:50 UTC) #1

Description was changed from

==========
Fullscreen bubble: Now speaks the bubble text if a11y enabled.

DO NOT SUBMIT; THIS IS BROKEN.

BUG=577011
==========

to

==========
Fullscreen bubble: Now speaks the bubble text if a11y enabled.

DO NOT SUBMIT; THIS IS BROKEN.

BUG=577011
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages