Populate VisibleSecurityState::displayed_mixed_content on iOS

Populate VisibleSecurityState::displayed_mixed_content on iOS

On iOS, we know whether the page has displayed insecure content; this CL
propagates that information to SecurityStateModel::VisibleSecurityState.

As far as I can tell, the resulting value isn't used by anything on the iOS
port, so this CL will not result in any visible change at the current time.

Committed: https://crrev.com/69846f8f71eb69287a44ddcaa447167ad7ec6fb7
Cr-Commit-Position: refs/heads/master@{#372051}

[blundell, 2016-01-12 15:50:35]

blundell@chromium.org changed reviewers:
+ eugenebut@chromium.org, lgarron@chromium.org

[blundell, 2016-01-12 15:50:35]

will get an OWNERS stamp once you review it

[Eugene But (OOO till 7-30), 2016-01-12 17:11:30]

lgtm

https://codereview.chromium.org/1578273002/diff/1/ios/chrome/browser/ssl/ios_...
File ios/chrome/browser/ssl/ios_chrome_security_state_model_client.cc (right):

https://codereview.chromium.org/1578273002/diff/1/ios/chrome/browser/ssl/ios_...
ios/chrome/browser/ssl/ios_chrome_security_state_model_client.cc:101:
state->displayed_mixed_content =
FWIW the following code seems to be cleaner:

state->displayed_mixed_content =
    ssl.content_status & web::SSLStatus::DISPLAYED_INSECURE_CONTENT;

But it's up to you.

[blundell, 2016-01-13 10:40:47]

https://codereview.chromium.org/1578273002/diff/1/ios/chrome/browser/ssl/ios_...
File ios/chrome/browser/ssl/ios_chrome_security_state_model_client.cc (right):

https://codereview.chromium.org/1578273002/diff/1/ios/chrome/browser/ssl/ios_...
ios/chrome/browser/ssl/ios_chrome_security_state_model_client.cc:101:
state->displayed_mixed_content =
On 2016/01/12 17:11:30, eugenebut wrote:
> FWIW the following code seems to be cleaner:
> 
> state->displayed_mixed_content =
>     ssl.content_status & web::SSLStatus::DISPLAYED_INSECURE_CONTENT;
> 
> But it's up to you.

This is copied over from //chrome, going to leave as-is.

[blundell, 2016-01-26 09:59:32]

blundell@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[blundell, 2016-01-26 09:59:33]

+stuartmorgan for OWNERS

[stuartmorgan, 2016-01-27 23:32:25]

lgtm

[blundell, 2016-01-28 08:36:41]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2016-01-28 08:36:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578273002/1

[commit-bot: I haz the power, 2016-01-28 09:04:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 09:05:36]

Description was changed from

==========
Populate VisibleSecurityState::displayed_mixed_content on iOS

On iOS, we know whether the page has displayed insecure content; this CL
propagates that information to SecurityStateModel::VisibleSecurityState.

As far as I can tell, the resulting value isn't used by anything on the iOS
port, so this CL will not result in any visible change at the current time.
==========

to

==========
Populate VisibleSecurityState::displayed_mixed_content on iOS

On iOS, we know whether the page has displayed insecure content; this CL
propagates that information to SecurityStateModel::VisibleSecurityState.

As far as I can tell, the resulting value isn't used by anything on the iOS
port, so this CL will not result in any visible change at the current time.

Committed: https://crrev.com/69846f8f71eb69287a44ddcaa447167ad7ec6fb7
Cr-Commit-Position: refs/heads/master@{#372051}
==========

[commit-bot: I haz the power, 2016-01-28 09:05:36]

Patchset 1 (id:??) landed as
https://crrev.com/69846f8f71eb69287a44ddcaa447167ad7ec6fb7
Cr-Commit-Position: refs/heads/master@{#372051}