third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp - Issue 1578263006: Add metrics for usage of permission features from iframes in blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

Issue 1578263006: Add metrics for usage of permission features from iframes in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('k') | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

index 2ed43245c95c4e4b999096293a5b150fe6fba48f..d8419394bfd418f06d0fb8bf9f9269b6bd7ebdf6 100644

--- a/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp

@@ -125,6 +125,7 @@ bool UserMediaRequest::isSecureContextUse(String& errorMessage)

if (document->isSecureContext(errorMessage)) {

UseCounter::count(document->frame(), UseCounter::GetUserMediaSecureOrigin);

+ UseCounter::countCrossOriginIframe(*document, UseCounter::GetUserMediaSecureOriginIframe);

OriginsUsingFeatures::countAnyWorld(*document, OriginsUsingFeatures::Feature::GetUserMediaSecureOrigin);

return true;

}

@@ -132,6 +133,7 @@ bool UserMediaRequest::isSecureContextUse(String& errorMessage)

// While getUserMedia is blocked on insecure origins, we still want to

// count attempts to use it.

UseCounter::countDeprecation(document->frame(), UseCounter::GetUserMediaInsecureOrigin);

+ UseCounter::countCrossOriginIframe(*document, UseCounter::GetUserMediaInsecureOriginIframe);

OriginsUsingFeatures::countAnyWorld(*document, OriginsUsingFeatures::Feature::GetUserMediaInsecureOrigin);

return false;

}