Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.h

Issue 1578263006: Add metrics for usage of permission features from iframes in blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h b/third_party/WebKit/Source/core/frame/UseCounter.h
index fb179a8399889bccd401aac0de5be7ee6df22858..3d0aa46637d9a79ada9cf7f40059fc3fa3355ae4 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -994,6 +994,14 @@ public:
V8PromiseAccept = 1138,
V8PromiseDefer = 1139,
EventScoped = 1140,
+ GeolocationInsecureOriginIframe = 1141,
+ GeolocationSecureOriginIframe = 1142,
+ RequestMIDIAccessIframe = 1143,
+ GetUserMediaInsecureOriginIframe = 1144,
+ GetUserMediaSecureOriginIframe = 1145,
+ ElementRequestPointerLockIframe = 1146,
+ NotificationAPIInsecureOriginIframe = 1147,
+ NotificationAPISecureOriginIframe = 1148,
// Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots.
@@ -1036,6 +1044,10 @@ public:
static void countDeprecationIfNotPrivateScript(v8::Isolate*, ExecutionContext*, Feature);
static String deprecationMessage(Feature);
+ // Count only features if they're being used in an iframe which does not
+ // have script access into the top level document.
+ static void countCrossOriginIframe(const Document&, Feature);
+
// Return whether the Feature was previously counted for this document.
// NOTE: only for use in testing.
static bool isCounted(Document&, Feature);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698