src/regexp/regexp-ast.cc - Issue 1578253005: [regexp] implement character classes for unicode regexps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/regexp-ast.cc

Issue 1578253005: [regexp] implement character classes for unicode regexps. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: lookaround builder Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp/regexp-ast.cc

diff --git a/src/regexp/regexp-ast.cc b/src/regexp/regexp-ast.cc

index 31c93b114f14d0f0bb03be1b0f7ba499a616b0d0..b5c2bb6d91d9f3b060366171a21bf645ff8a805a 100644

--- a/src/regexp/regexp-ast.cc

+++ b/src/regexp/regexp-ast.cc

@@ -172,9 +172,9 @@ void* RegExpUnparser::VisitAlternative(RegExpAlternative* that, void* data) {

void RegExpUnparser::VisitCharacterRange(CharacterRange that) {

- os_ << AsUC16(that.from());

+ os_ << AsUC32(that.from());

if (!that.IsSingleton()) {

- os_ << "-" << AsUC16(that.to());

+ os_ << "-" << AsUC32(that.to());

}