Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 1578253002: Don't try to store POST data for a nil CWRSessionEntry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 2dc4d955b92c5ef8a0e0bcdfe4b00db2c8204e27..4b1e6cbe77b0871fed6141881059cf73c84bc29c 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -2821,8 +2821,11 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
}
if ([[request HTTPMethod] isEqualToString:@"POST"]) {
- [self cachePOSTDataForRequest:request
- inSessionEntry:[self currentSessionEntry]];
+ CRWSessionEntry* currentEntry = [self currentSessionEntry];
+ // TODO(crbug.com/570699): Remove this check once it's no longer possible to
+ // have no current entries.
+ if (currentEntry)
+ [self cachePOSTDataForRequest:request inSessionEntry:currentEntry];
}
return YES;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698