Revert 250094 "Make UI strings consistent in the 2nd person - cr..."

Revert 250094 "Make UI strings consistent in the 2nd person - cr..."

Revert reason: CHECKs because of missing $1 in one of the messages.

> Make UI strings consistent in the 2nd person - crbug.com/156975
>
> BUG=156975
>
> Review URL: https://codereview.chromium.org/145683002

TBR=edwardjung@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250100

[Jói, 2014-02-10 15:07:34]

Committed patchset #1 manually as r250100 (tree was closed).

[edwardjung, 2014-02-10 16:35:06]

lgtm

https://codereview.chromium.org/157823003/diff/1/trunk/src/chrome/app/generat...
File trunk/src/chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/157823003/diff/1/trunk/src/chrome/app/generat...
trunk/src/chrome/app/generated_resources.grd:10160: +        </message>
Do you have any suggestions as how to fix this? Per http://goo.gl/6614MQ the
suggestion is not to use PRODUCT_NAME placeholders. If I just leave the changes
in here in this file, it doesn't pass the presubmit checks. 

Thanks.

[Jói, 2014-02-10 16:41:54]

There would need to be a code change as well as a string change (as
part of the same patch) to avoid using placeholders. The reason for
the test failures this caused is that the code that replaces
placeholders checks that it actually found placeholders to replace,
and currently there is code that for at least one of the strings you
changed assumes it has a placeholder.

Cheers,
Jói


On Mon, Feb 10, 2014 at 4:35 PM,  <edwardjung@chromium.org> wrote:
> lgtm
>
>
>
>
>
https://codereview.chromium.org/157823003/diff/1/trunk/src/chrome/app/generat...
> File trunk/src/chrome/app/generated_resources.grd (right):
>
>
https://codereview.chromium.org/157823003/diff/1/trunk/src/chrome/app/generat...
> trunk/src/chrome/app/generated_resources.grd:10160: +        </message>
> Do you have any suggestions as how to fix this? Per http://goo.gl/6614MQ
> the suggestion is not to use PRODUCT_NAME placeholders. If I just leave
> the changes in here in this file, it doesn't pass the presubmit checks.
>
> Thanks.
>
> https://codereview.chromium.org/157823003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[edwardjung, 2014-02-10 17:19:07]

Thanks Joi, a Chromium newbie follow up question I hope you don't mind me
asking. 

Would updating the strings in the dictionary in BrowserOptionsHandler:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

from this:
{ "autoLaunchText", IDS_AUTOLAUNCH_TEXT, IDS_PRODUCT_NAME },

to this:
{ "autoLaunchText", IDS_AUTOLAUNCH_TEXT },

resolve this? Or would there need to be updates to the unit tests too.

Many thanks,

Edward

[Jói, 2014-02-10 17:55:40]

Hi Edward,

That should likely resolve it, not 100% sure though. I think if you
make sure to test your change on trybots matching the bots that failed
(looks like they are all debug bots, so e.g. linux, mac, win rather
than linux_rel, mac_rel, win_rel which are the defaults IIRC) then you
should be fine.

Cheers,
Jói



On Mon, Feb 10, 2014 at 5:19 PM,  <edwardjung@chromium.org> wrote:
> Thanks Joi, a Chromium newbie follow up question I hope you don't mind me
> asking.
>
> Would updating the strings in the dictionary in BrowserOptionsHandler:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
>
> from this:
> { "autoLaunchText", IDS_AUTOLAUNCH_TEXT, IDS_PRODUCT_NAME },
>
> to this:
> { "autoLaunchText", IDS_AUTOLAUNCH_TEXT },
>
> resolve this? Or would there need to be updates to the unit tests too.
>
> Many thanks,
>
> Edward
>
>
> https://codereview.chromium.org/157823003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.