Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1578193006:
Fix behavior of Document.body getter (Closed)
|
Created:
4 years, 11 months ago by rwlbuis Modified:
4 years, 11 months ago Reviewers:
tkent CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, sof, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix behavior of Document.body getter
According to [1], the body element is the first child of the html
element that is either a body element or a frameset element. The
current version does not check that the parent node is the html
element, so add that check.
Behavior matches Firefox.
[1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2
BUG=490511
Committed: https://crrev.com/c482a252feb7731369dcc483b0b145efaae7aba6
Cr-Commit-Position: refs/heads/master@{#369654}
Patch Set 1 #Patch Set 2 : V2 #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== 490511 WIP BUG= ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The previous version did not actually check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ==========
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The previous version did not actually check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ==========
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ==========
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ==========
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ==========
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. BUG=490511 [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ==========
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. Behavior matches Firefox. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ==========
rob.buis@samsung.com changed reviewers: + tkent@chromium.org
PTAL.
Let's just update Document::body(). Inconsistency between body() and bodyForBinding() is confusing.
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. In order to not slow down the body method which is used internally, add a bodyForBinding method. Behavior matches Firefox. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. Behavior matches Firefox. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ==========
On 2016/01/14 23:03:40, tkent wrote: > Let's just update Document::body(). Inconsistency between body() and > bodyForBinding() is confusing. Fixed :) PTAL.
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578193006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578193006/20001
Message was sent while issue was closed.
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. Behavior matches Firefox. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. Behavior matches Firefox. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. Behavior matches Firefox. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 ========== to ========== Fix behavior of Document.body getter According to [1], the body element is the first child of the html element that is either a body element or a frameset element. The current version does not check that the parent node is the html element, so add that check. Behavior matches Firefox. [1] https://html.spec.whatwg.org/multipage/dom.html#the-body-element-2 BUG=490511 Committed: https://crrev.com/c482a252feb7731369dcc483b0b145efaae7aba6 Cr-Commit-Position: refs/heads/master@{#369654} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c482a252feb7731369dcc483b0b145efaae7aba6 Cr-Commit-Position: refs/heads/master@{#369654}
Message was sent while issue was closed.
> BUG=490511 I recommend to file new bug specific to this problem. (and I'd be happy if https://docs.google.com/spreadsheets/d/1-xlh6co6QYC-KVof27sVxjA7yuUFvYcaul3vE... is updated)
Message was sent while issue was closed.
On 2016/01/15 02:15:39, tkent wrote: > > BUG=490511 > > I recommend to file new bug specific to this problem. Sorry about that! I created crbug.com/578145 after the CL landed. > (and I'd be happy if > https://docs.google.com/spreadsheets/d/1-xlh6co6QYC-KVof27sVxjA7yuUFvYcaul3vE... > is updated) I was not aware of the spreadsheet, that seems handy! I added the new bug url. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
