Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1578193002: Remove ChromeToolbarModel (Closed)

Created:
4 years, 11 months ago by blundell
Modified:
4 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeToolbarModel SecurityStateModel has now been componentized, which means that ToolbarModel can refer to it. This change renders ChromeToolbarModel unnecessary. BUG=515071 Committed: https://crrev.com/c1f77e79555cf4cbb4d41f45cc26b70cbcaf4b32 Cr-Commit-Position: refs/heads/master@{#369134}

Patch Set 1 #

Patch Set 2 : Nit #

Patch Set 3 : Self-review #

Patch Set 4 : Add DEPS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -67 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
D chrome/browser/ui/toolbar/chrome_toolbar_model.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/toolbar/chrome_toolbar_model.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/test_toolbar_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/toolbar.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/toolbar/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A components/toolbar/DEPS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/toolbar/toolbar_model.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
blundell
4 years, 11 months ago (2016-01-12 14:33:37 UTC) #4
Peter Kasting
LGTM
4 years, 11 months ago (2016-01-12 23:21:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578193002/60001
4 years, 11 months ago (2016-01-13 09:52:30 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-13 10:56:37 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 10:57:42 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c1f77e79555cf4cbb4d41f45cc26b70cbcaf4b32
Cr-Commit-Position: refs/heads/master@{#369134}

Powered by Google App Engine
This is Rietveld 408576698