Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1578173002:
SampleApp: Cleanup SkOSWindow_SDL (Closed)
|
Created:
4 years, 11 months ago by Kimmo Kinnunen Modified:
4 years, 11 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@sampleapp-02.02-skwindow_win-cleanup Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionSampleApp: Cleanup SkOSWindow_SDL
Implements:
* Event loop event waiting (no busy loop)
** Skia timers
* Proper window sizing and resizing
* MSAA on X11 (previously it did not use MSAA at all)
* Changes requested colorspace from 565 to 8888
to match non-SDL variants
* Context creation clearing (color and stencil mask)
* Opens the window in 640x480 by default on desktop.
Removes dead code.
BUG=skia:4733
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1578173002
Committed: https://skia.googlesource.com/skia/+/abc0c8216b8e162b8de74de005f883cb84bd254b
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 27 (12 generated)
Description was changed from ========== SampleApp: Cleanup SkWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) Removes dead code. TODO: not tested on android, since visualbench does not start. BUG=skia:4733 ========== to ========== SampleApp: Cleanup SkWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) Removes dead code. TODO: not tested on android, since visualbench does not start. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
kkinnunen@nvidia.com changed reviewers: + joshualitt@chromium.org
Description was changed from ========== SampleApp: Cleanup SkWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) Removes dead code. TODO: not tested on android, since visualbench does not start. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SampleApp: Cleanup SkWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA on X11 (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) Removes dead code. TODO: not tested on android, since visualbench does not start. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
On 2016/01/12 12:47:40, Kimmo Kinnunen wrote: lgtm
On 2016/01/12 14:16:57, joshualitt wrote: > On 2016/01/12 12:47:40, Kimmo Kinnunen wrote: > Also, Chris should have a fix which should let you launch SDL VisualBench on Android. It *should* work, assuming it hasn't bitrotted
chris, do you have that?
On 2016/01/13 05:51:11, Kimmo Kinnunen wrote: > chris, do you have that? I believe Josh is referring to this: https://codereview.chromium.org/1473033002/ Visualbench doesn't launch for me on Android unless I apply this change. However, visualbench *does* launch correctly for Josh in ToT, and the change actually breaks it for him. It's a big mystery.
On 2016/01/13 05:55:37, Chris Dalton wrote: > On 2016/01/13 05:51:11, Kimmo Kinnunen wrote: > > chris, do you have that? > > I believe Josh is referring to this: > > https://codereview.chromium.org/1473033002/?_ga=1.244523653.1001920031.143892... > > Visualbench doesn't launch for me on Android unless I apply this change. Joshua, it's not this. git checkout master rm -rf out GYP_DEFINES="skia_use_sdl=1" platform_tools/android/bin/android_ninja VisualBench_APK GYP_DEFINES="skia_use_sdl=1" platform_tools/android/bin/android_install_app VisualBench Tap on visualbench / run it with the script: 02-17 02:05:52.936 21264 21264 W NativeActivity: ANativeActivity_onCreate not found 02-17 02:05:52.937 21264 21264 D AndroidRuntime: Shutting down VM 02-17 02:05:52.941 21264 21264 E AndroidRuntime: FATAL EXCEPTION: main 02-17 02:05:52.941 21264 21264 E AndroidRuntime: Process: com.skia.visualbench, PID: 21264 02-17 02:05:52.941 21264 21264 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.skia.visualbench/com.skia.VisualBenchActivity}: java.lang.IllegalArgumentException: Unable to load native library: /data/app/com.skia.visualbench-1/lib/arm/libvisualbench.so > It's a big mystery. Yeah.. It must be that in bash the word "SkiaSample" needs different escaping for the string after it than the word "VisualBench".
On 2016/01/13 12:23:15, Kimmo Kinnunen wrote: > On 2016/01/13 05:55:37, Chris Dalton wrote: > > On 2016/01/13 05:51:11, Kimmo Kinnunen wrote: > > > chris, do you have that? > > > > I believe Josh is referring to this: > > > > > https://codereview.chromium.org/1473033002/?_ga=1.244523653.1001920031.143892... > > > > Visualbench doesn't launch for me on Android unless I apply this change. > > Joshua, it's not this. > git checkout master > rm -rf out > GYP_DEFINES="skia_use_sdl=1" platform_tools/android/bin/android_ninja > VisualBench_APK > GYP_DEFINES="skia_use_sdl=1" platform_tools/android/bin/android_install_app > VisualBench > > Tap on visualbench / run it with the script: > > 02-17 02:05:52.936 21264 21264 W NativeActivity: ANativeActivity_onCreate not > found > 02-17 02:05:52.937 21264 21264 D AndroidRuntime: Shutting down VM > 02-17 02:05:52.941 21264 21264 E AndroidRuntime: FATAL EXCEPTION: main > 02-17 02:05:52.941 21264 21264 E AndroidRuntime: Process: com.skia.visualbench, > PID: 21264 > 02-17 02:05:52.941 21264 21264 E AndroidRuntime: java.lang.RuntimeException: > Unable to start activity > ComponentInfo{com.skia.visualbench/com.skia.VisualBenchActivity}: > java.lang.IllegalArgumentException: Unable to load native library: > /data/app/com.skia.visualbench-1/lib/arm/libvisualbench.so > > > It's a big mystery. > > Yeah.. It must be that in bash the word "SkiaSample" needs different escaping > for the string after it than the word "VisualBench". platform_tools/android/bin/android_ninja VisualBenchSDL_APK and platform_tools/android/bin/android_install_app VisualBenchSDL For some reason I need a command line argument too, so for launching: platform_tools/android/bin/android_launch_app VisualBench --match text This is all poorly integrated and documented, mostly because we as a team need to figure out what we're doing, but the above sequence works for me on TOT. I think you will need chris' launch script.
Description was changed from ========== SampleApp: Cleanup SkWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA on X11 (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) Removes dead code. TODO: not tested on android, since visualbench does not start. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SampleApp: Cleanup SkOSWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA on X11 (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) * Opens the window in 640x480 by default on desktop. Removes dead code. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by kkinnunen@nvidia.com
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1557843002 Patch 40001). Please resolve the dependency and try again.
The CQ bit was checked by kkinnunen@nvidia.com
The patchset sent to the CQ was uploaded after l-g-t-m from joshualitt@google.com Link to the patchset: https://codereview.chromium.org/1578173002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578173002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
kkinnunen@nvidia.com changed reviewers: + bsalomon@google.com, djsollen@google.com, reed@google.com
bsalomon@google.com, reed@google.com, djsollen@google.com: PTAL, public API change.
On 2016/01/14 13:03:56, Kimmo Kinnunen wrote: > mailto:bsalomon@google.com, mailto:reed@google.com, mailto:djsollen@google.com: PTAL, public API > change. lgtm
The CQ bit was checked by kkinnunen@nvidia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578173002/40001
Message was sent while issue was closed.
Description was changed from ========== SampleApp: Cleanup SkOSWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA on X11 (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) * Opens the window in 640x480 by default on desktop. Removes dead code. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== SampleApp: Cleanup SkOSWindow_SDL Implements: * Event loop event waiting (no busy loop) ** Skia timers * Proper window sizing and resizing * MSAA on X11 (previously it did not use MSAA at all) * Changes requested colorspace from 565 to 8888 to match non-SDL variants * Context creation clearing (color and stencil mask) * Opens the window in 640x480 by default on desktop. Removes dead code. BUG=skia:4733 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/abc0c8216b8e162b8de74de005f883cb84bd254b ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/abc0c8216b8e162b8de74de005f883cb84bd254b |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
