Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2850)

Unified Diff: base/allocator/BUILD.gn

Issue 1578163002: Enable tcmalloc VDSO support only on x86 to reduce static initializers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ghh, comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/tcmalloc/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/BUILD.gn
diff --git a/base/allocator/BUILD.gn b/base/allocator/BUILD.gn
index c04a0e1417d3900ad2bcccfab2d2b0b6066c2304..9d09a357af6efcaf2d73a551ee46cc1c54409b01 100644
--- a/base/allocator/BUILD.gn
+++ b/base/allocator/BUILD.gn
@@ -118,10 +118,7 @@ if (is_win) {
if (use_allocator == "tcmalloc") {
# tcmalloc currently won't compile on Android.
- # TODO(crbug.com/559766) this should be a source_set but
- # there are static initializers that get accidentally linked
- # into chrome from vdso_support.cc that need to be addressed first.
- static_library("tcmalloc") {
+ source_set("tcmalloc") {
tcmalloc_dir = "//third_party/tcmalloc/chromium"
# Don't check tcmalloc's includes. These files include various files like
@@ -292,4 +289,4 @@ if (use_allocator == "tcmalloc") {
deps += [ "//base/third_party/dynamic_annotations" ]
}
-} # !is_android
+} # use_allocator == "tcmalloc"
« no previous file with comments | « no previous file | third_party/tcmalloc/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698