Make all site engagement tests run on Android.

Make all site engagement tests run on Android.

The current site engagement tests are a) based on
BrowserWithTestWindowTest (which doesn't run on Android); or b) not
compiled as part of unit_tests on Android. This CL refactors the tests
so that they compile, run, and pass on Android.

BUG=575509
Committed: https://crrev.com/330431253754734118f7f1dc842af1f81c6c485c
Cr-Commit-Position: refs/heads/master@{#369364}

[dominickn, 2016-01-12 06:13:21]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org, calamity@chromium.org

[dominickn, 2016-01-12 06:13:21]

PTAL, thanks!

[benwells, 2016-01-13 23:14:32]

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service_unittest.cc (left):

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service_unittest.cc:379:
base::CommandLine::ForCurrentProcess()->AppendSwitch(
How come the flag isn't needed?

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service_unittest.cc (right):

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service_unittest.cc:398: GURL& url,
Nit: Should this be const& as well?

[dominickn, 2016-01-14 01:17:41]

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service_unittest.cc (left):

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service_unittest.cc:379:
base::CommandLine::ForCurrentProcess()->AppendSwitch(
On 2016/01/13 23:14:32, benwells wrote:
> How come the flag isn't needed?

The service is normally kicked off in tab_helpers.cc, but this test runner
doesn't instantiate a browser or tabs. That makes the flag meaningless here -
GetForProfile just creates the service when called.

There should be separate browser tests (one for desktop and one for Android)
which turn the flag on and check that everything is working.

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service_unittest.cc (right):

https://codereview.chromium.org/1578133002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service_unittest.cc:398: GURL& url,
On 2016/01/13 23:14:32, benwells wrote:
> Nit: Should this be const& as well?

Done.

[benwells, 2016-01-14 01:58:49]

lgtm

[calamity, 2016-01-14 06:34:22]

lgtm

[dominickn, 2016-01-14 06:45:28]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2016-01-14 06:45:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578133002/20001

[commit-bot: I haz the power, 2016-01-14 07:41:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 07:44:29]

Description was changed from

==========
Make all site engagement tests run on Android.

The current site engagement tests are a) based on
BrowserWithTestWindowTest (which doesn't run on Android); or b) not
compiled as part of unit_tests on Android. This CL refactors the tests
so that they compile, run, and pass on Android.

BUG=575509
==========

to

==========
Make all site engagement tests run on Android.

The current site engagement tests are a) based on
BrowserWithTestWindowTest (which doesn't run on Android); or b) not
compiled as part of unit_tests on Android. This CL refactors the tests
so that they compile, run, and pass on Android.

BUG=575509

Committed: https://crrev.com/330431253754734118f7f1dc842af1f81c6c485c
Cr-Commit-Position: refs/heads/master@{#369364}
==========

[commit-bot: I haz the power, 2016-01-14 07:44:30]

Patchset 2 (id:??) landed as
https://crrev.com/330431253754734118f7f1dc842af1f81c6c485c
Cr-Commit-Position: refs/heads/master@{#369364}