Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 157813013: Update the order of named properties on HTMLCollection objects (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update the order of named properties on HTMLCollection objects Update the order of named properties on HTMLCollection objects to match a recent DOM specification fix: https://github.com/whatwg/dom/commit/8b9338049201d075b1cae365562dfb40fe46d567 If an Element contributes both its id and its name, its id should always precede its name when enumerating. This is more consistent with the HTML5 spec and with the behavior of Firefox 27. R=haraken, arv, tkent BUG=341269 TEST=fast/dom/htmlcollection-enumerated-properties.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167090

Patch Set 1 #

Patch Set 2 : Reup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M LayoutTests/fast/dom/htmlcollection-enumerated-properties.html View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 10 months ago (2014-02-12 16:24:35 UTC) #1
haraken
LGTM. (The side-by-side diff is broken though.)
6 years, 10 months ago (2014-02-12 16:47:14 UTC) #2
Inactive
On 2014/02/12 16:47:14, haraken wrote: > LGTM. (The side-by-side diff is broken though.) Sorry about ...
6 years, 10 months ago (2014-02-12 16:56:58 UTC) #3
arv (Not doing code reviews)
LGTM
6 years, 10 months ago (2014-02-12 17:03:44 UTC) #4
Inactive
tkent, could you please approve as API owner?
6 years, 10 months ago (2014-02-13 02:07:09 UTC) #5
haraken
tkent is off today. jochen@: could you take a look at the API change?
6 years, 10 months ago (2014-02-13 02:08:15 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-13 09:05:14 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-13 13:14:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/157813013/110001
6 years, 10 months ago (2014-02-13 13:15:07 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 14:08:37 UTC) #10
Message was sent while issue was closed.
Change committed as 167090

Powered by Google App Engine
This is Rietveld 408576698