Issue 15781008: Warn on private members.

Issue 15781008: Warn on private members. (Closed)

Created:
7 years, 7 months ago by Johnni Winther

Modified:
7 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Warn on private members. BUG= R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23462

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Fix bug and add regression. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+200 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2	6 chunks	+32 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js/private_test.dart	View	1 2	1 chunk	+165 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/15781008/diff/2001/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/15781008/diff/2001/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode586 sdk/lib/_internal/compiler/implementation/typechecker.dart:586: reportTypeWarning( Maybe share more of this code with ...

7 years, 6 months ago (2013-05-31 07:13:17 UTC) #2

Johnni Winther

https://codereview.chromium.org/15781008/diff/2001/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/15781008/diff/2001/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode586 sdk/lib/_internal/compiler/implementation/typechecker.dart:586: reportTypeWarning( On 2013/05/31 07:13:17, kasperl wrote: > Maybe share ...

7 years, 6 months ago (2013-05-31 11:32:37 UTC) #3

Johnni Winther

7 years, 6 months ago (2013-05-31 11:41:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r23462 (presubmit successful).

Expand Messages | Collapse Messages