Implements an UpdateClient::SendUninstallPing API for the

Implements an UpdateClient::SendUninstallPing API for the
extension manager to send uninstall pings through Omaha.

BUG=501641
Committed: https://crrev.com/805aa031138fcaa9bff81322aea044f421d39d3e
Cr-Commit-Position: refs/heads/master@{#369594}

[Sorin Jianu, 2016-01-12 02:17:35]

Description was changed from

==========
Implements an UpdateClient::SendUninstallPing API for the
extension manager to send uninstall pings through Omaha.

BUG=501641
==========

to

==========
Implements an UpdateClient::SendUninstallPing API for the
extension manager to send uninstall pings through Omaha.

BUG=501641
==========

[Sorin Jianu, 2016-01-12 02:17:35]

sorin@chromium.org changed reviewers:
+ asargent@chromium.org, waffles@chromium.org

[waffles, 2016-01-12 02:26:38]

lgtm % errorcode vs extracode1.

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
File components/update_client/ping_manager.cc (right):

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
components/update_client/ping_manager.cc:138: "<app appid=\"%s\" version=\"%s\"
nextversion=\"%s\">"
Just a note that we prefer <event nextversion> to <app nextversion>, but let's
not fix it this changelist.

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
File components/update_client/update_client.cc (right):

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
components/update_client/update_client.cc:241: item.error_code = reason;
I'm not sure about overloading error_code to be the uninstall reason. asargent@:
Do we need to transmit the uninstall reason?
If so, I would rather use extracode1.

[Sorin Jianu, 2016-01-12 02:54:45]

sorin@chromium.org changed reviewers:
+ bauerb@chromium.org

[Sorin Jianu, 2016-01-12 03:24:06]

Thank you, PTAL.

Antony, Berhard, please, I need owner's approval for 
extensions\browser\updater\update_service_unittest.cc and
chrome\browser\ui\webui\components_ui.cc respectively.

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
File components/update_client/ping_manager.cc (right):

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
components/update_client/ping_manager.cc:138: "<app appid=\"%s\" version=\"%s\"
nextversion=\"%s\">"
On 2016/01/12 02:26:38, waffles wrote:
> Just a note that we prefer <event nextversion> to <app nextversion>, but let's
> not fix it this changelist.

Acknowledged.

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
File components/update_client/update_client.cc (right):

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
components/update_client/update_client.cc:241: item.error_code = reason;
On 2016/01/12 02:26:38, waffles wrote:
> I'm not sure about overloading error_code to be the uninstall reason.
asargent@:
> Do we need to transmit the uninstall reason?
> If so, I would rather use extracode1.

Done.

[Bernhard Bauer, 2016-01-12 09:41:23]

Web UI LGTM.

[asargent_no_longer_on_chrome, 2016-01-14 21:57:54]

lgtm

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
File components/update_client/update_client.cc (right):

https://codereview.chromium.org/1578083002/diff/20001/components/update_clien...
components/update_client/update_client.cc:241: item.error_code = reason;
On 2016/01/12 03:24:06, Sorin Jianu wrote:
> On 2016/01/12 02:26:38, waffles wrote:
> > I'm not sure about overloading error_code to be the uninstall reason.
> asargent@:
> > Do we need to transmit the uninstall reason?
> > If so, I would rather use extracode1.
> 
> Done.

Just to confirm, yes, we do want to be able to send an uninstall reason.

[Sorin Jianu, 2016-01-14 22:07:02]

The CQ bit was checked by sorin@chromium.org

[Sorin Jianu, 2016-01-14 22:07:02]

The patchset sent to the CQ was uploaded after l-g-t-m from waffles@chromium.org
Link to the patchset: https://codereview.chromium.org/1578083002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-14 22:08:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578083002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578083002/60001

[commit-bot: I haz the power, 2016-01-14 23:01:38]

Description was changed from

==========
Implements an UpdateClient::SendUninstallPing API for the
extension manager to send uninstall pings through Omaha.

BUG=501641
==========

to

==========
Implements an UpdateClient::SendUninstallPing API for the
extension manager to send uninstall pings through Omaha.

BUG=501641
==========

[commit-bot: I haz the power, 2016-01-14 23:01:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-14 23:04:19]

Description was changed from

==========
Implements an UpdateClient::SendUninstallPing API for the
extension manager to send uninstall pings through Omaha.

BUG=501641
==========

to

==========
Implements an UpdateClient::SendUninstallPing API for the
extension manager to send uninstall pings through Omaha.

BUG=501641

Committed: https://crrev.com/805aa031138fcaa9bff81322aea044f421d39d3e
Cr-Commit-Position: refs/heads/master@{#369594}
==========

[commit-bot: I haz the power, 2016-01-14 23:04:20]

Patchset 4 (id:??) landed as
https://crrev.com/805aa031138fcaa9bff81322aea044f421d39d3e
Cr-Commit-Position: refs/heads/master@{#369594}