Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1578033003: Revert of For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy webkit_headless. (Closed)

Created:
4 years, 11 months ago by dogben
Modified:
4 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, jcgregorio, reed1, f(malita)
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy webkit_headless. (patchset #2 id:20001 of https://codereview.chromium.org/1568633002/ ) Reason for revert: Removed legacy saveflags in internal cl/111889802. Original issue's description: > For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy webkit_headless. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1568633002 > > Committed: https://skia.googlesource.com/skia/+/85c8d06540942531fe3440fafa2a2825f128251a TBR=mtklein@google.com,reed@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1ad0415b031805019b97c6c1afa229037a14fcc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M BUILD.public View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dogben
Created Revert of For Google3, enable SK_SUPPORT_LEGACY_SAVEFLAGS; required by legacy webkit_headless.
4 years, 11 months ago (2016-01-11 22:38:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578033003/1
4 years, 11 months ago (2016-01-11 22:38:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1578033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1578033003/1
4 years, 11 months ago (2016-01-11 23:00:55 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 23:01:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1ad0415b031805019b97c6c1afa229037a14fcc6

Powered by Google App Engine
This is Rietveld 408576698