Reset browser.check_default_browser on update.

chrome/common/pref_names.cc

Index: chrome/common/pref_names.cc
diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc
index 86aececa08cf6ba7318ab0b5b9d4fb92213b5eca..69b184d95586f921a7594afb22228a525e04155a 100644
--- a/chrome/common/pref_names.cc
+++ b/chrome/common/pref_names.cc
@@ -946,6 +946,10 @@ const char kPluginsResourceCacheUpdate[] = "plugins.resource_cache_update";
 // Boolean that indicates whether we should check if we are the default browser
 // on start-up.
 const char kCheckDefaultBrowser[] = "browser.check_default_browser";
+// Boolean that indicates whether the kCheckDefaultBrowser preference should be
+// reset on start-up.

[Peter Kasting, 2016/01/11 22:49:57]

This is a bit misleading as-is, because the actual implementation ignores this
value unless we're on Win 10+.

We should either document this as only affecting Win 10+, and possibly rename
the pref, or else we should change the implementation so that instead of
checking for Win 10+ in ShowDefaultBrowserPrompt(), we register this pref with a
default value based on whether we're on Win 10+:

  bool reset_check_default = false;
#if defined(OS_WIN)
  reset_check_default = base::win::GetVersion() >= base::win::VERSION_WIN10;
#endif
  registry->RegisterBooleanPref(prefs::kResetCheckDefaultBrowser,
                                reset_check_default);

This latter route is probably better.

[Patrick Monette, 2016/01/11 23:24:02]

Done.

+const char kResetCheckDefaultBrowser[] =
+    "browser.should_reset_check_default_browser";
 
 // Policy setting whether default browser check should be disabled and default
 // browser registration should take place.