Reset browser.check_default_browser on update.

Reset browser.check_default_browser on browser update.

BUG=576490
Committed: https://crrev.com/cff89e9b8eeabe4ab1ae204212eb893483a51636
Cr-Commit-Position: refs/heads/master@{#368753}

[Patrick Monette, 2016-01-11 20:14:23]

Description was changed from

==========
Reset browser.check_default_browser on update.

BUG=531649
==========

to

==========
Reset browser.check_default_browser on update.

BUG=531649
==========

[Patrick Monette, 2016-01-11 20:18:06]

pmonette@chromium.org changed reviewers:
+ msw@chromium.org

[Patrick Monette, 2016-01-11 20:18:06]

PTAL.

One shot reset of browser.check_default_browser preference for Windows 10 users.

[Patrick Monette, 2016-01-11 22:16:46]

pmonette@chromium.org changed reviewers:
- msw@chromium.org

[Patrick Monette, 2016-01-11 22:17:53]

pmonette@chromium.org changed reviewers:
+ pkasting@chromium.org

[Patrick Monette, 2016-01-11 22:17:53]

Please take a look.

[Patrick Monette, 2016-01-11 22:18:03]

Description was changed from

==========
Reset browser.check_default_browser on update.

BUG=531649
==========

to

==========
Reset browser.check_default_browser on browser update.

BUG=531649
==========

[Peter Kasting, 2016-01-11 22:49:57]

Is there something on the bug which documents our intent to reset this flag once
and why?  It'd be nice to have the written justification for this somewhere.

https://codereview.chromium.org/1578013002/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/1578013002/diff/1/chrome/common/pref_names.cc...
chrome/common/pref_names.cc:950: // reset on start-up.
This is a bit misleading as-is, because the actual implementation ignores this
value unless we're on Win 10+.

We should either document this as only affecting Win 10+, and possibly rename
the pref, or else we should change the implementation so that instead of
checking for Win 10+ in ShowDefaultBrowserPrompt(), we register this pref with a
default value based on whether we're on Win 10+:

  bool reset_check_default = false;
#if defined(OS_WIN)
  reset_check_default = base::win::GetVersion() >= base::win::VERSION_WIN10;
#endif
  registry->RegisterBooleanPref(prefs::kResetCheckDefaultBrowser,
                                reset_check_default);

This latter route is probably better.

[Patrick Monette, 2016-01-11 23:24:02]

https://codereview.chromium.org/1578013002/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/1578013002/diff/1/chrome/common/pref_names.cc...
chrome/common/pref_names.cc:950: // reset on start-up.
On 2016/01/11 22:49:57, Peter Kasting wrote:
> This is a bit misleading as-is, because the actual implementation ignores this
> value unless we're on Win 10+.
> 
> We should either document this as only affecting Win 10+, and possibly rename
> the pref, or else we should change the implementation so that instead of
> checking for Win 10+ in ShowDefaultBrowserPrompt(), we register this pref with
a
> default value based on whether we're on Win 10+:
> 
>   bool reset_check_default = false;
> #if defined(OS_WIN)
>   reset_check_default = base::win::GetVersion() >= base::win::VERSION_WIN10;
> #endif
>   registry->RegisterBooleanPref(prefs::kResetCheckDefaultBrowser,
>                                 reset_check_default);
> 
> This latter route is probably better.

Done.

[Peter Kasting, 2016-01-11 23:25:14]

LGTM

[Patrick Monette, 2016-01-11 23:26:35]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-01-11 23:28:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578013002/20001

[commit-bot: I haz the power, 2016-01-11 23:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 23:44:17]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Patrick Monette, 2016-01-11 23:59:32]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-01-11 23:59:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1578013002/#ps40001
(title: "Missing line")

[commit-bot: I haz the power, 2016-01-12 00:01:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1578013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1578013002/40001

[jschuh, 2016-01-12 01:12:51]

Description was changed from

==========
Reset browser.check_default_browser on browser update.

BUG=531649
==========

to

==========
Reset browser.check_default_browser on browser update.

BUG=576490
==========

[commit-bot: I haz the power, 2016-01-12 01:19:02]

Description was changed from

==========
Reset browser.check_default_browser on browser update.

BUG=576490
==========

to

==========
Reset browser.check_default_browser on browser update.

BUG=576490
==========

[commit-bot: I haz the power, 2016-01-12 01:19:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 01:20:15]

Description was changed from

==========
Reset browser.check_default_browser on browser update.

BUG=576490
==========

to

==========
Reset browser.check_default_browser on browser update.

BUG=576490

Committed: https://crrev.com/cff89e9b8eeabe4ab1ae204212eb893483a51636
Cr-Commit-Position: refs/heads/master@{#368753}
==========

[commit-bot: I haz the power, 2016-01-12 01:20:15]

Patchset 3 (id:??) landed as
https://crrev.com/cff89e9b8eeabe4ab1ae204212eb893483a51636
Cr-Commit-Position: refs/heads/master@{#368753}