Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/bots/compiler.py

Issue 15780009: Enable browser controller on ff and chrome on normal waterfall (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 23234)
+++ tools/bots/compiler.py (working copy)
@@ -108,6 +108,31 @@
flags = [x for x in flags if not '=' in x]
return ('%s tests %s' % (name, ' '.join(flags))).strip()
+# TODO(ricow): remove this once we have browser controller drivers for all
+# supported platforms.
+def UseBrowserController(runtime, system):
+ supported_platforms = {
+ 'linux': ['ff', 'chromeOnAndroid', 'chrome'],
+ 'mac': [],
+ 'windows': []
+ }
+ # Platforms that we run on the fyi waterfall only.
+ fyi_supported_platforms = {
+ 'linux': [],
+ 'mac': ['safari'],
+ 'windows': []
+ }
+
+ if (runtime in supported_platforms[system]):
+ return True
+
+ if (os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main" and
+ runtime in fyi_supported_platforms[system]):
+ return True
+
+ return False
+
+
IsFirstTestStepCall = True
def TestStep(name, mode, system, compiler, runtime, targets, flags):
step_name = TestStepName(name, flags)
@@ -140,9 +165,7 @@
else:
cmd.extend(['--progress=buildbot', '-v'])
- # TODO(ricow): temporary hack to run on fyi with --use_browser_controller
- if (os.environ.get('BUILDBOT_SCHEDULER') == "fyi-main" and
- runtime in ['chrome', 'ff', 'chromeOnAndroid']):
+ if UseBrowserController(runtime, system):
cmd.append('--use_browser_controller')
global IsFirstTestStepCall
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698