Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1577973002: Merge to m48: Fix volume slider to emit value changed events and do not focus system tray it\ (Closed)

Created:
4 years, 11 months ago by David Tseng
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Fix volume slider to emit value changed events and do not focus system tray it em for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The fo\ rmer has some logic to detect when ChromeVox is on. If so, it tries to focus t\Fix volume slider to emit value changed events and do not focus system\ tray item for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The fo\ rmer has some logic to detect when ChromeVox is on. If so, it tries to focus t\ he first item. This is problematic because PopupDetailedView is transient and \ disappears. The general bug is that ChromeVox gets the focus event and flips itself to com\ -UU-:----F1 cl_descriptionbhyjBt Top L1 (Fundamental) ------------------ For information about GNU Emacs and the GNU system, type C-h C-a. -UUU:----F1 *scratch* All L1 (Fundamental) -------------------------- Warning: Unknown defun property `special' in gfeeds-find # Enter a description of the change. Fix volume slider to emit value changed events and do not focus system tray it\ em for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The fo\ rmer has some logic to detect when ChromeVox is on. If so, it tries to focus t\Fix volume slider to emit value changed events and do not focus system tray item for transient views. SystemTray::ShowItems gets called by SystemTrayItem::PopupDetailedView. The former has some logic to detect when ChromeVox is on. If so, it tries to focus the first item. This is problematic because PopupDetailedView is transient and disappears. The general bug is that ChromeVox gets the focus event and flips itself to compat mode. However, true focus still lives in the web content. BUG=559339 NOTRY=true NOPRESUBMIT=true TBR= Review URL: https://codereview.chromium.org/1523953004 Cr-Commit-Position: refs/heads/master@{#365565} (cherry picked from commit b6cac2bcff25657f70fcd69f414be4884675a443)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M ash/system/audio/volume_view.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577973002/1
4 years, 11 months ago (2016-01-11 19:33:44 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:39:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698