Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: services/media/framework/parts/reader.cc

Issue 1577953002: Motown in-proc streaming framework used to implement media services. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Sync, updates based on feedback, some functions declared const. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/media/framework/parts/reader.cc
diff --git a/services/media/framework/parts/reader.cc b/services/media/framework/parts/reader.cc
new file mode 100644
index 0000000000000000000000000000000000000000..24ac7a1093a0036c6bd98833d9da11e3d7933709
--- /dev/null
+++ b/services/media/framework/parts/reader.cc
@@ -0,0 +1,37 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "services/media/framework/parts/file_reader.h"
+#include "services/media/framework/parts/reader.h"
+#include "url/gurl.h"
+
+namespace mojo {
+namespace media {
+
+Result Reader::Create(const GURL& gurl, ReaderPtr* reader_out) {
+ if (!gurl.is_valid()) {
+ return Result::kInvalidArgument;
+ }
+
+ ReaderPtr reader = nullptr;
+ if (gurl.SchemeIsFile()) {
+ reader = FileReader::New();
+ }
+ // TODO(dalesat): More schemes.
jeffbrown 2016/02/02 05:35:48 Honestly this code doesn't belong in your framewor
dalesat 2016/02/02 21:46:40 I agree that *most* of the resolution should be do
+
+ if (reader == nullptr) {
+ return Result::kUnsupportedOperation;
+ }
+
+ Result result = reader->Init(gurl);
+ if (result == Result::kOk) {
+ *reader_out = reader;
+ }
+
+ return result;
+}
+
+} // namespace media
+} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698