services/media/framework/models/demand.h - Issue 1577953002: Motown in-proc streaming framework used to implement media services.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/media/framework/models/demand.h

Issue 1577953002: Motown in-proc streaming framework used to implement media services. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Sync, updates based on feedback, some functions declared const. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« services/media/framework/models/active_source.h ('K') | « services/media/framework/models/active_source.h ('k') | services/media/framework/models/lpcm_frames.h » ('j') | services/media/framework/models/lpcm_frames.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MOJO_MEDIA_MODELS_DEMAND_H_

	6 #define MOJO_MEDIA_MODELS_DEMAND_H_

	7

	8 namespace mojo {

	9 namespace media {

	10

	11 // Expresses packet demand.

	12 enum class Demand {

	13 // Ordered such that (kNegative < kNeutral < kPositive).
	jeffbrown 2016/02/02 05:35:47 If you intend for these values to be ordered, assi If you intend for these values to be ordered, assign them values. eg. -1, 0, 1. Also, please add some comments to explain them. This is a central concept in your design. dalesat 2016/02/02 21:46:39 Done. Show quoted text On 2016/02/02 05:35:47, jeffbrown wrote: > If you intend for these values to be ordered, assign them values. eg. -1, 0, 1. > > Also, please add some comments to explain them. This is a central concept in > your design. Done.
	14 kNegative,

	15 kNeutral,

	16 kPositive

	17 };

	18

	19 } // namespace media

	20 } // namespace mojo

	21

	22 #endif // MOJO_MEDIA_MODELS_DEMAND_H_

OLD	NEW