Get correct GLVersion for Mesa to avoid GrContext creation failure

Get correct GLVersion for Mesa to avoid GrContext creation failure.

[yunchao, 2013-05-28 03:58:31]

Get correct GLVersion for Mesa. For example, OpenGL version string for May be
"1.4 Mesa 9.0", then the previous code of GrGLGetVersionFromString thought the
GLVersion is 1.4. But "Mesa 9.x" means its GLVersion is 3.1. The mapping of Mesa
Version to GLVersion, see http://www.mesa3d.org/intro.html.

[yunchao, 2013-05-28 13:25:21]

On 2013/05/28 03:58:31, yunchao.he wrote:
just more clear: For example, OpenGL version string for Mesa may be "1.4 Mesa
9.0", then the previous code of GrGLGetVersionFromString thought the GLVersion
is 1.4. It would refuse to create GrContext and failed because it thought this
GLVersion doesn't have array and element_array buffer objects. But "Mesa 9.x"
means its GLVersion is 3.1, it supports array and element_array buffer object
already. The mapping of Mesa Version to GLVersion, see
http://www.mesa3d.org/intro.html.

[bsalomon, 2013-05-28 13:30:25]

On 2013/05/28 03:58:31, yunchao.he wrote:
> Get correct GLVersion for Mesa. For example, OpenGL version string for May be
> "1.4 Mesa 9.0", then the previous code of GrGLGetVersionFromString thought the
> GLVersion is 1.4. But "Mesa 9.x" means its GLVersion is 3.1. The mapping of
Mesa
> Version to GLVersion, see http://www.mesa3d.org/intro.html.

Thanks for this. I had no idea Mesa used a different version string format.
Overall this looks good, but I have one request:

Can you remove the new function from the header and in the cpp file put the
function into an anonymous namespace. Also, could you rename it to
lowercase_underscore_style()

[robertphillips, 2013-05-28 13:38:55]

https://codereview.chromium.org/15779009/diff/8003/src/gpu/gl/GrGLUtil.cpp
File src/gpu/gl/GrGLUtil.cpp (right):

https://codereview.chromium.org/15779009/diff/8003/src/gpu/gl/GrGLUtil.cpp#ne...
src/gpu/gl/GrGLUtil.cpp:50: 
return bool rather than int?

May be an informative comment like: "// Mesa stores its version string as X.Y
Mesa Z.W where ...

https://codereview.chromium.org/15779009/diff/8003/src/gpu/gl/GrGLUtil.cpp#ne...
src/gpu/gl/GrGLUtil.cpp:73: default:
weird spacing here?

[epoger, 2013-05-28 15:35:23]

[removing myself from reviewers list, feel free to add me back in if desired]

[yunchao, 2013-05-29 02:23:48]

On 2013/05/28 13:38:55, robertphillips wrote:
> https://codereview.chromium.org/15779009/diff/8003/src/gpu/gl/GrGLUtil.cpp
> File src/gpu/gl/GrGLUtil.cpp (right):
> 
>
https://codereview.chromium.org/15779009/diff/8003/src/gpu/gl/GrGLUtil.cpp#ne...
> src/gpu/gl/GrGLUtil.cpp:50: 
> return bool rather than int?
> 
> May be an informative comment like: "// Mesa stores its version string as X.Y
> Mesa Z.W where ...
> 
>
https://codereview.chromium.org/15779009/diff/8003/src/gpu/gl/GrGLUtil.cpp#ne...
> src/gpu/gl/GrGLUtil.cpp:73: default:
> weird spacing here?

Hi, bsalomon and robertphillips, this patch has been changed according to your
good suggestions. please review it.

[robertphillips, 2013-05-29 12:52:09]

lgtm - do you want me to commit this for you?

[bsalomon, 2013-05-29 13:14:08]

I went ahead and landed it with some minor reformatting and comments here:
https://code.google.com/p/skia/source/detail?r=9309

[yunchao, 2013-05-30 02:17:45]

On 2013/05/29 13:14:08, bsalomon wrote:
> I went ahead and landed it with some minor reformatting and comments here:
> https://code.google.com/p/skia/source/detail?r=9309

Thank you, robertphillips and bsalomon. Then I will close this issue.