Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: runtime/vm/raw_object.h

Issue 15779006: Add deoptimization history to optimized functions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/flow_graph_inliner.cc ('K') | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h (revision 23072)
+++ runtime/vm/raw_object.h (working copy)
@@ -604,6 +604,7 @@
RawArray* parameter_names_;
RawCode* code_; // Compiled code for the function.
RawCode* unoptimized_code_; // Unoptimized code, keep it after optimization.
+ RawArray* deopt_history_; // Deopt Ids of past deoptimizations.
RawObject* data_; // Additional data specific to the function kind.
RawObject** to() {
return reinterpret_cast<RawObject**>(&ptr()->data_);
@@ -614,7 +615,7 @@
intptr_t usage_counter_; // Incremented while function is running.
int16_t num_fixed_parameters_;
int16_t num_optional_parameters_; // > 0: positional; < 0: named.
- uint16_t deoptimization_counter_;
+ int16_t deoptimization_counter_;
srdjan 2013/05/28 10:48:49 Please document what negative counter means.
Florian Schneider 2013/05/29 08:50:20 It should never be negative. I just made this cons
uint16_t kind_tag_;
uint16_t optimized_instruction_count_;
uint16_t optimized_call_site_count_;
« runtime/vm/flow_graph_inliner.cc ('K') | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698