Add deoptimization history to optimized functions.

runtime/vm/flow_graph_inliner.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_inliner.h"
 
 #include "vm/compiler.h"
 #include "vm/flags.h"
 #include "vm/flow_graph.h"
 #include "vm/flow_graph_builder.h"
@@ skipping 594 matching lines @@
       }
 
       // If depth is less or equal to threshold recursively add call sites.
       if (inlining_depth_ < FLAG_inlining_depth_threshold) {
         collected_call_sites_->FindCallSites(callee_graph);
       }
 
       // Add the function to the cache.
       if (!in_cache) function_cache_.Add(parsed_function);
 
+      // Functions can be inlined before they are optimized.
+      // If not yet present, allocate deoptimization history array.
+      Array& deopt_history = Array::Handle(function.deopt_history());
+      if (deopt_history.IsNull()) {
+        deopt_history = Array::New(FLAG_deoptimization_counter_threshold);
+        function.set_deopt_history(deopt_history);

[srdjan, 2013/05/28 10:48:49]

This code is used repeatedly. How about factoring it out into
Function::NeedsDeoptHistory() ?

[Florian Schneider, 2013/05/29 08:50:20]

Good idea.

+      }
+
       // Build succeeded so we restore the bailout jump.
       inlined_ = true;
       inlined_size_ += size;
       isolate->set_long_jump_base(base);
       isolate->set_deopt_id(prev_deopt_id);
 
       call_data->callee_graph = callee_graph;
       call_data->parameter_stubs = param_stubs;
       call_data->exit_collector = exit_collector;
       TRACE_INLINING(OS::Print("     Success\n"));
@@ skipping 709 matching lines @@
         OS::Print("After Inlining of %s\n", flow_graph_->
                   parsed_function().function().ToFullyQualifiedCString());
         FlowGraphPrinter printer(*flow_graph_);
         printer.PrintBlocks();
       }
     }
   }
 }
 
 }  // namespace dart