Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 15779004: Fix embedded new-space pointer in LCmpObjectEqAndBranch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 // Push and pop the registers that can hold pointers. 265 // Push and pop the registers that can hold pointers.
266 void PushSafepointRegisters() { pushad(); } 266 void PushSafepointRegisters() { pushad(); }
267 void PopSafepointRegisters() { popad(); } 267 void PopSafepointRegisters() { popad(); }
268 // Store the value in register/immediate src in the safepoint 268 // Store the value in register/immediate src in the safepoint
269 // register stack slot for register dst. 269 // register stack slot for register dst.
270 void StoreToSafepointRegisterSlot(Register dst, Register src); 270 void StoreToSafepointRegisterSlot(Register dst, Register src);
271 void StoreToSafepointRegisterSlot(Register dst, Immediate src); 271 void StoreToSafepointRegisterSlot(Register dst, Immediate src);
272 void LoadFromSafepointRegisterSlot(Register dst, Register src); 272 void LoadFromSafepointRegisterSlot(Register dst, Register src);
273 273
274 void LoadHeapObject(Register result, Handle<HeapObject> object); 274 void LoadHeapObject(Register result, Handle<HeapObject> object);
275 void CmpHeapObject(Register reg, Handle<HeapObject> object);
275 void PushHeapObject(Handle<HeapObject> object); 276 void PushHeapObject(Handle<HeapObject> object);
276 277
277 void LoadObject(Register result, Handle<Object> object) { 278 void LoadObject(Register result, Handle<Object> object) {
278 ALLOW_HANDLE_DEREF(isolate(), "heap object check"); 279 ALLOW_HANDLE_DEREF(isolate(), "heap object check");
279 if (object->IsHeapObject()) { 280 if (object->IsHeapObject()) {
280 LoadHeapObject(result, Handle<HeapObject>::cast(object)); 281 LoadHeapObject(result, Handle<HeapObject>::cast(object));
281 } else { 282 } else {
282 Set(result, Immediate(object)); 283 Set(result, Immediate(object));
283 } 284 }
284 } 285 }
285 286
287 void CmpObject(Register reg, Handle<Object> object) {
288 ALLOW_HANDLE_DEREF(isolate(), "heap object check");
289 if (object->IsHeapObject()) {
290 CmpHeapObject(reg, Handle<HeapObject>::cast(object));
291 } else {
292 cmp(reg, Immediate(object));
293 }
294 }
295
286 // --------------------------------------------------------------------------- 296 // ---------------------------------------------------------------------------
287 // JavaScript invokes 297 // JavaScript invokes
288 298
289 // Set up call kind marking in ecx. The method takes ecx as an 299 // Set up call kind marking in ecx. The method takes ecx as an
290 // explicit first parameter to make the code more readable at the 300 // explicit first parameter to make the code more readable at the
291 // call sites. 301 // call sites.
292 void SetCallKind(Register dst, CallKind kind); 302 void SetCallKind(Register dst, CallKind kind);
293 303
294 // Invoke the JavaScript function code by either calling or jumping. 304 // Invoke the JavaScript function code by either calling or jumping.
295 void InvokeCode(Register code, 305 void InvokeCode(Register code,
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 } \ 1042 } \
1033 masm-> 1043 masm->
1034 #else 1044 #else
1035 #define ACCESS_MASM(masm) masm-> 1045 #define ACCESS_MASM(masm) masm->
1036 #endif 1046 #endif
1037 1047
1038 1048
1039 } } // namespace v8::internal 1049 } } // namespace v8::internal
1040 1050
1041 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 1051 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698