apply --match to image file names too, like we do for .skps

apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g. on the bots).
This cuts about 6 minutes off the Debug CQ trybot.

BUG=skia:4768
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1577873002

Committed: https://skia.googlesource.com/skia/+/6f0ff91c6561549a1ea8de3e8896b80a584c45b9

[mtklein_C, 2016-01-11 15:40:49]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
   ....
After:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
           0.05 real         0.03 user         0.01 sys

BUG=skia:
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
   ....
After:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
           0.05 real         0.03 user         0.01 sys

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-01-11 15:41:11]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
   ....
After:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
           0.05 real         0.03 user         0.01 sys

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
 4.65 real         4.41 user         0.19 sysAfter:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
           0.05 real         0.03 user         0.01 sys

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-01-11 15:41:23]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
 4.65 real         4.41 user         0.19 sysAfter:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
           0.05 real         0.03 user         0.01 sys

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
           0.05 real         0.03 user         0.01 sys

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-01-11 15:41:53]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
           0.05 real         0.03 user         0.01 sys

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-11 15:43:42]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 15:43:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577873002/20001

[mtklein_C, 2016-01-11 15:43:49]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[mtklein_C, 2016-01-11 15:54:24]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).

BUG=skia:4768
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-11 15:58:28]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).

BUG=skia:4768
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).

BUG=
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-01-11 15:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 15:59:00]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-01-11 15:59:58]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).

BUG=
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).
This cuts about 6 minutes off the Debug CQ trybot.

BUG=
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-11 16:01:03]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).
This cuts about 6 minutes off the Debug CQ trybot.

BUG=
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).
This cuts about 6 minutes off the Debug CQ trybot.

BUG=skia:4768
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-11 16:51:59]

lgtm

[mtklein, 2016-01-11 17:03:29]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-01-11 17:03:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577873002/20001

[commit-bot: I haz the power, 2016-01-11 17:04:23]

Description was changed from

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).
This cuts about 6 minutes off the Debug CQ trybot.

BUG=skia:4768
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
apply --match to image file names too, like we do for .skps

This should make skipping an image much cheaper.

Before:
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        4.65 real         4.41 user         0.19 sys
   $ time out/Release/nanobench --images resources/ --match sdkjlfasjlfds
        0.05 real         0.03 user         0.01 sys

The effect should be much more dramatic when there are more images to skip (e.g.
on the bots).
This cuts about 6 minutes off the Debug CQ trybot.

BUG=skia:4768
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/6f0ff91c6561549a1ea8de3e8896b80a584c45b9
==========

[commit-bot: I haz the power, 2016-01-11 17:04:24]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6f0ff91c6561549a1ea8de3e8896b80a584c45b9

[msarett, 2016-01-11 19:55:49]

https://codereview.chromium.org/1577873002/diff/20001/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1577873002/diff/20001/bench/nanobench.cpp#new...
bench/nanobench.cpp:746: if (SkCommandLineFlags::ShouldSkip(FLAGS_match,
path.c_str())) {
I should have noticed this on my review, but this actually causes a problem for
my most common use case.

out/Release/nanobench --match Codec --images pngs/

"Codec" won't match the image name, so all of the tests will be skipped.  On the
other hand, if this is how everything else works, I'm still fine with it.  There
are tons of workarounds for me.

[scroggo, 2016-02-03 15:30:00]

scroggo@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2016-02-03 15:30:01]

https://codereview.chromium.org/1577873002/diff/20001/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/1577873002/diff/20001/bench/nanobench.cpp#new...
bench/nanobench.cpp:746: if (SkCommandLineFlags::ShouldSkip(FLAGS_match,
path.c_str())) {
On 2016/01/11 19:55:49, msarett wrote:
> I should have noticed this on my review, but this actually causes a problem
for
> my most common use case.
> 
> out/Release/nanobench --match Codec --images pngs/
> 
> "Codec" won't match the image name, so all of the tests will be skipped.  On
the
> other hand, if this is how everything else works, I'm still fine with it. 
There
> are tons of workarounds for me.

Proposed fix in crrev.com/1663103002