[heap] Parallel newspace evacuation, semispace copy, and compaction \o/

src/heap/store-buffer.cc

Index: src/heap/store-buffer.cc
diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc
index a8a1e5bbf1efe78d7b92d3e23b6822d621119fc7..10eeca585f8ad1a0704e7f9b9ccfa2e2d25d8f50 100644
--- a/src/heap/store-buffer.cc
+++ b/src/heap/store-buffer.cc
@@ -182,11 +182,7 @@ void StoreBuffer::EnsureSpace(intptr_t space_needed) {
 // Sample the store buffer to see if some pages are taking up a lot of space
 // in the store buffer.
 void StoreBuffer::ExemptPopularPages(int prime_sample_step, int threshold) {
-  PointerChunkIterator it(heap_);
-  MemoryChunk* chunk;
-  while ((chunk = it.next()) != NULL) {
-    chunk->set_store_buffer_counter(0);
-  }
+  HashMap store_buffer_counts(HashMap::PointersMatch, 16);
   bool created_new_scan_on_scavenge_pages = false;
   MemoryChunk* previous_chunk = NULL;
   for (Address* p = old_start_; p < old_top_; p += prime_sample_step) {
@@ -197,12 +193,15 @@ void StoreBuffer::ExemptPopularPages(int prime_sample_step, int threshold) {
     } else {
       containing_chunk = MemoryChunk::FromAnyPointerAddress(heap_, addr);
     }
-    int old_counter = containing_chunk->store_buffer_counter();
+    HashMap::Entry* e = store_buffer_counts.LookupOrInsert(
+        containing_chunk,
+        static_cast<uint32_t>(reinterpret_cast<uintptr_t>(containing_chunk)));

[ulan, 2016/01/15 10:44:43]

Shifting out the lower zero bits of the address will reduce collisions  because
the hashmap implementation just looks at the lower bits of the hash.

[Michael Lippautz, 2016/01/15 13:09:53]

Done in 
  https://codereview.chromium.org/1593583002/

+    intptr_t old_counter = bit_cast<intptr_t>(e->value);
     if (old_counter >= threshold) {
       containing_chunk->set_scan_on_scavenge(true);
       created_new_scan_on_scavenge_pages = true;
     }
-    containing_chunk->set_store_buffer_counter(old_counter + 1);
+    (*bit_cast<intptr_t*>(&e->value))++;
     previous_chunk = containing_chunk;
   }
   if (created_new_scan_on_scavenge_pages) {