Fix SVG sizing in crossfaded images

Fix SVG sizing in crossfaded images

Wrap SVGImages inside SVGImageForContainer to maintain the correct
size. SVGImages are shared between all places the same resource is
used and the wrapper is necessary to get the proper size for a
particular instantiation.

BUG=574172
Committed: https://crrev.com/3ca78bf60493da8b2b7ad63f59bd169cb00a4947
Cr-Commit-Position: refs/heads/master@{#368816}

[davve, 2016-01-11 15:12:20]

Description was changed from

==========
Fix SVG sizing in crossfaded images

Wrap SVGImages inside SVGImageForContainer to maintain the correct
size. SVGImages are shared between all places the same resource is
used and the wrapper is necessary to get the proper size for the
specific instantiation.

BUG=574172
==========

to

==========
Fix SVG sizing in crossfaded images

Wrap SVGImages inside SVGImageForContainer to maintain the correct
size. SVGImages are shared between all places the same resource is
used and the wrapper is necessary to get the proper size for a
particular instantiation.

BUG=574172
==========

[davve, 2016-01-11 15:12:40]

davve@opera.com changed reviewers:
+ fs@opera.com

[davve, 2016-01-11 15:12:41]

PTAL

[fs, 2016-01-11 15:26:46]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2016-01-11 15:26:46]

+pdr for platform/

LGTM w/ nit

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff.html
(right):

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff.html:7:
background-image: -webkit-cross-fade(url("data:image/svg+xml,<svg viewBox='0 0
100 100' xmlns='http://www.w3.org/2000/svg'><circle cx='50' cy='50' r='35'
fill='green'/></svg>"), url("data:image/svg+xml,<svg viewBox='0 0 100 100'
xmlns='http://www.w3.org/2000/svg'><circle cx='50' cy='50' r='25'
fill='green'/></svg>"), 0);
(A test with the 'percentage' argument having a value > 0 might be good too.)

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp (right):

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp:222: // TODO(davve):
Pass along proper URL to the SVG wrappers
Should be possible to dig out from m_{from,to}Value I think, but that's probably
better as a follow-up anyway.

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp:225: fromImageRef =
SVGImageForContainer::create(toSVGImage(fromImage), size, 1.0, KURL());
Nit: 1.0 -> 1 (or 1.0f since it's a float)

[davve, 2016-01-11 16:02:43]

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff.html
(right):

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff.html:7:
background-image: -webkit-cross-fade(url("data:image/svg+xml,<svg viewBox='0 0
100 100' xmlns='http://www.w3.org/2000/svg'><circle cx='50' cy='50' r='35'
fill='green'/></svg>"), url("data:image/svg+xml,<svg viewBox='0 0 100 100'
xmlns='http://www.w3.org/2000/svg'><circle cx='50' cy='50' r='25'
fill='green'/></svg>"), 0);
On 2016/01/11 15:26:46, fs wrote:
> (A test with the 'percentage' argument having a value > 0 might be good too.)

Done.

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp (right):

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp:222: // TODO(davve):
Pass along proper URL to the SVG wrappers
On 2016/01/11 15:26:46, fs wrote:
> Should be possible to dig out from m_{from,to}Value I think, but that's
probably
> better as a follow-up anyway.

Follow-up planned.

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp:225: fromImageRef =
SVGImageForContainer::create(toSVGImage(fromImage), size, 1.0, KURL());
On 2016/01/11 15:26:46, fs wrote:
> Nit: 1.0 -> 1 (or 1.0f since it's a float)

Done.

[fs, 2016-01-11 16:05:45]

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff.html
(right):

https://codereview.chromium.org/1577843002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/images/cross-fade-svg-size-diff.html:7:
background-image: -webkit-cross-fade(url("data:image/svg+xml,<svg viewBox='0 0
100 100' xmlns='http://www.w3.org/2000/svg'><circle cx='50' cy='50' r='35'
fill='green'/></svg>"), url("data:image/svg+xml,<svg viewBox='0 0 100 100'
xmlns='http://www.w3.org/2000/svg'><circle cx='50' cy='50' r='25'
fill='green'/></svg>"), 0);
On 2016/01/11 at 16:02:43, David Vest wrote:
> On 2016/01/11 15:26:46, fs wrote:
> > (A test with the 'percentage' argument having a value > 0 might be good
too.)
> 
> Done.

Thanks.

[davve, 2016-01-11 16:11:44]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 16:12:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577843002/20001

[davve, 2016-01-11 16:17:39]

The CQ bit was unchecked by davve@opera.com

[davve, 2016-01-11 16:18:22]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 16:18:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577843002/40001

[pdr., 2016-01-11 19:32:30]

On 2016/01/11 at 16:18:53, commit-bot wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1577843002/40001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1577843002/40001

LGTM

[commit-bot: I haz the power, 2016-01-11 19:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 19:46:36]

Dry run: This issue passed the CQ dry run.

[davve, 2016-01-12 07:27:18]

The CQ bit was checked by davve@opera.com

[davve, 2016-01-12 07:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1577843002/#ps40001
(title: "Adjust test to make it more obvious when it fails")

[commit-bot: I haz the power, 2016-01-12 07:27:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577843002/40001

[commit-bot: I haz the power, 2016-01-12 07:33:43]

Description was changed from

==========
Fix SVG sizing in crossfaded images

Wrap SVGImages inside SVGImageForContainer to maintain the correct
size. SVGImages are shared between all places the same resource is
used and the wrapper is necessary to get the proper size for a
particular instantiation.

BUG=574172
==========

to

==========
Fix SVG sizing in crossfaded images

Wrap SVGImages inside SVGImageForContainer to maintain the correct
size. SVGImages are shared between all places the same resource is
used and the wrapper is necessary to get the proper size for a
particular instantiation.

BUG=574172
==========

[commit-bot: I haz the power, 2016-01-12 07:33:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 07:34:41]

Description was changed from

==========
Fix SVG sizing in crossfaded images

Wrap SVGImages inside SVGImageForContainer to maintain the correct
size. SVGImages are shared between all places the same resource is
used and the wrapper is necessary to get the proper size for a
particular instantiation.

BUG=574172
==========

to

==========
Fix SVG sizing in crossfaded images

Wrap SVGImages inside SVGImageForContainer to maintain the correct
size. SVGImages are shared between all places the same resource is
used and the wrapper is necessary to get the proper size for a
particular instantiation.

BUG=574172

Committed: https://crrev.com/3ca78bf60493da8b2b7ad63f59bd169cb00a4947
Cr-Commit-Position: refs/heads/master@{#368816}
==========

[commit-bot: I haz the power, 2016-01-12 07:34:42]

Patchset 3 (id:??) landed as
https://crrev.com/3ca78bf60493da8b2b7ad63f59bd169cb00a4947
Cr-Commit-Position: refs/heads/master@{#368816}