Fixes up batch-mode release of utility process.

Fixes up batch-mode release of utility process.

When running in single-process mode, e.g. during unit tests, the utility
process cannot terminate the process and instead closes its channel to trigger
cleanup.  Ending batchmode triggers process termination for the multi-process
mode, but does nothing during single-process mode, leading to test timeout.
This can be fixed by adding the single-process mode logic to the EndBatchMode
code path.

BUG=341935
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251209

[Drew Haven, 2014-02-07 18:34:28]

John,

Would you mind taking a look at this tiny CL for me?

I noticed my tests always hang when writing some unit-tests that use the utility
thread in batch mode along with InProcessUtilityThreadHelper.  I figured out
that since the browser-side has a refcounted objected the utility thread's
channel was never shut down and so the thread stayed alive.  This simple change
seemed to fix things.  Hopefully it's the right solution.  Another option would
be to replicate the logic in ReleaseProcessIfNeeded, but this seems cleaner.

Drew

[Drew Haven, 2014-02-07 18:48:12]

On 2014/02/07 18:34:28, Drew Haven wrote:
> John,
> 
> Would you mind taking a look at this tiny CL for me?
> 
> I noticed my tests always hang when writing some unit-tests that use the
utility
> thread in batch mode along with InProcessUtilityThreadHelper.  I figured out
> that since the browser-side has a refcounted objected the utility thread's
> channel was never shut down and so the thread stayed alive.  This simple
change
> seemed to fix things.  Hopefully it's the right solution.  Another option
would
> be to replicate the logic in ReleaseProcessIfNeeded, but this seems cleaner.
> 
> Drew

I replicated this from another CL and foolishly didn't compile before uploading.
 I fixed it to call properly now.

[Drew Haven, 2014-02-13 03:14:26]

Matt,

Would you mind taking a look at this tiny CL for me?  I sent it to jam@, but
he's OOO this week.  I think I described it in the summary and previous message,
but here's the summary just in case:

I noticed my tests always hang when writing some unit-tests that use the utility
thread in batch mode along with InProcessUtilityThreadHelper. I figured out that
the tests are running in single-process mode and so StopBatchMode wasn't closing
the channel and then the browser-side objects aren't detecting the shutdown and
getting collected.

Thanks,

Drew

[Matt Perry, 2014-02-13 18:26:41]

I can't say I really understand it, but if it fixes the bug, LGTM.

[Drew Haven, 2014-02-13 20:48:57]

The CQ bit was checked by haven@chromium.org

[commit-bot: I haz the power, 2014-02-13 20:52:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haven@chromium.org/157783002/50001

[commit-bot: I haz the power, 2014-02-14 00:37:48]

Change committed as 251209