Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1577813002: [wasm] Avoid crashing if parsing fails in asm -> wasm. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Avoid crashing if parsing fails in asm -> wasm. R=ahaas@chromium.org LOG=Y BUG=chromium:575369 Committed: https://crrev.com/1ab97e901ba7539c924c83c50323cf1771115eb3 Cr-Commit-Position: refs/heads/master@{#33206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/wasm/wasm-js.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 11 months ago (2016-01-11 13:31:17 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-11 13:33:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577813002/1
4 years, 11 months ago (2016-01-11 13:52:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 13:59:14 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 14:00:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1ab97e901ba7539c924c83c50323cf1771115eb3
Cr-Commit-Position: refs/heads/master@{#33206}

Powered by Google App Engine
This is Rietveld 408576698