Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1577803002: [wasm] Rename the WASM object to _WASMEXP_. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename the WASM object to _WASMEXP_. R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 Committed: https://crrev.com/995c9fe3dc342395d03e1a47df94335b4adabaa0 Cr-Commit-Position: refs/heads/master@{#33251}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -82 lines) Patch
M src/wasm/wasm-js.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-575364.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 2 3 36 chunks +36 lines, -36 lines 0 comments Download
M test/mjsunit/wasm/calls.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/compile-run-basic.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/divrem-trap.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/ffi.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/indirect-calls.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/module-memory.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/params.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/stackwalk.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/unreachable.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/verify-function-basic-errors.js View 1 chunk +10 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/verify-function-simple.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/verify-module-basic-errors.js View 1 chunk +10 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/wasm-object-api.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
titzer
4 years, 11 months ago (2016-01-11 11:49:52 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-11 11:52:17 UTC) #2
titzer
On 2016/01/11 11:52:17, ahaas wrote: > lgtm I'll wait with landing this until the other ...
4 years, 11 months ago (2016-01-11 11:58:43 UTC) #3
bradnelson
lgtm
4 years, 11 months ago (2016-01-11 18:01:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577803002/60001
4 years, 11 months ago (2016-01-12 19:20:41 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-12 20:16:26 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 20:16:52 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/995c9fe3dc342395d03e1a47df94335b4adabaa0
Cr-Commit-Position: refs/heads/master@{#33251}

Powered by Google App Engine
This is Rietveld 408576698