chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 15778004: Mark some of tests that invoke RunExtensionSubset as disabled on Win - see bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 15778004: Mark some of tests that invoke RunExtensionSubset as disabled on Win - see bug. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index ebc309150f73964eec0e36eb479bc542fb5982f3..7c99bba9c7a540c752d014ede8a47a3a9946a6b8 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -79,7 +79,13 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestApi) {

ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_api.html")) << message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestSimple) {

+// Fails often on Windows dbg bots. http://crbug.com/177163

+#if defined(OS_WIN)

+#define MAYBE_WebRequestSimple DISABLED_WebRequestSimple

+#else

+#define MAYBE_WebRequestSimple WebRequestSimple

+#endif // defined(OS_WIN)

+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, MAYBE_WebRequestSimple) {

ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_simple.html")) <<

message_;

}

@@ -109,7 +115,13 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, MAYBE_WebRequestBlocking) {

message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestNewTab) {

+// Fails often on Windows dbg bots. http://crbug.com/177163

+#if defined(OS_WIN)

+#define MAYBE_WebRequestNewTab DISABLED_WebRequestNewTab

+#else

+#define MAYBE_WebRequestNewTab WebRequestNewTab

+#endif // defined(OS_WIN)

+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, MAYBE_WebRequestNewTab) {

// Wait for the extension to set itself up and return control to us.

ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_newTab.html"))

<< message_;