Issue 15778003: Implement binary "!=" operator in status file parser.

Issue 15778003: Implement binary "!=" operator in status file parser. (Closed)

Created:
7 years, 7 months ago by kustermann

Modified:
7 years, 7 months ago

Reviewers:
ricow1, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement binary "!=" operator in status file parser. R=ricow@google.com, whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23130

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -11 lines)			Patch
	M	tests/standalone/status_expression_test.dart	View		2 chunks	+28 lines, -0 lines	0 comments	Download
	M	tools/testing/dart/status_expression.dart	View	1	6 chunks	+19 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/15778003/diff/1/tools/testing/dart/status_expression.dart File tools/testing/dart/status_expression.dart (right): https://codereview.chromium.org/15778003/diff/1/tools/testing/dart/status_expression.dart#newcode87 tools/testing/dart/status_expression.dart:87: return negate ? !equals : equals; How about return ...

7 years, 7 months ago (2013-05-24 10:53:23 UTC) #2

ricow1

LGTM https://codereview.chromium.org/15778003/diff/1/tools/testing/dart/status_expression.dart File tools/testing/dart/status_expression.dart (right): https://codereview.chromium.org/15778003/diff/1/tools/testing/dart/status_expression.dart#newcode53 tools/testing/dart/status_expression.dart:53: // Tokens are : "(", ")", "$", ",", ...

7 years, 7 months ago (2013-05-24 10:54:38 UTC) #4

kustermann

Thank you. https://codereview.chromium.org/15778003/diff/1/tools/testing/dart/status_expression.dart File tools/testing/dart/status_expression.dart (right): https://codereview.chromium.org/15778003/diff/1/tools/testing/dart/status_expression.dart#newcode53 tools/testing/dart/status_expression.dart:53: // Tokens are : "(", ")", "$", ...

7 years, 7 months ago (2013-05-24 11:00:34 UTC) #5

kustermann

7 years, 7 months ago (2013-05-24 11:02:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r23130 (presubmit successful).

Expand Messages | Collapse Messages