[v8] don't crash when ArrayBuffer allocation fails

third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index 60a08f45f17fb57d0187a7c66cb405651f2c4aff..ef312a464381e2c483c643274e13af9b9b44c645 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -332,14 +332,14 @@ class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
     void* Allocate(size_t size) override
     {
         void* data;
-        WTF::ArrayBufferContents::allocateMemory(size, WTF::ArrayBufferContents::ZeroInitialize, data);
+        WTF::ArrayBufferContents::allocateMemoryOrNull(size, WTF::ArrayBufferContents::ZeroInitialize, data);

[haraken, 2016/01/14 01:52:33]

I'm a bit confused. If you call allocateMemoryOrNull and take no action when it
returns nullptr, you are just ignoring the allocation failure, aren't you?

[caitp (gmail), 2016/01/14 01:59:04]

The ArrayBufferAllocator is used (only) by v8, which throws a RangeError of
allocation fails (signaled by returning null here). The idea is to make the
Blink ArrayBufferAllocator honor the implicit contract that v8 expects

[haraken, 2016/01/14 02:17:31]

Thanks, makes sense. Can you add a comment about it?

         return data;
     }
 
     void* AllocateUninitialized(size_t size) override
     {
         void* data;
-        WTF::ArrayBufferContents::allocateMemory(size, WTF::ArrayBufferContents::DontInitialize, data);
+        WTF::ArrayBufferContents::allocateMemoryOrNull(size, WTF::ArrayBufferContents::DontInitialize, data);
         return data;
     }