[v8] don't crash when ArrayBuffer allocation fails

third_party/WebKit/Source/wtf/ArrayBufferContents.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 88 matching lines @@
 
 void ArrayBufferContents::allocateMemory(size_t size, InitializationPolicy policy, void*& data)
 {
     if (s_adjustAmountOfExternalAllocatedMemoryFunction)
         s_adjustAmountOfExternalAllocatedMemoryFunction(static_cast<int>(size));
     data = partitionAllocGeneric(WTF::Partitions::bufferPartition(), size, WTF_HEAP_PROFILER_TYPE_NAME(ArrayBufferContents));
     if (policy == ZeroInitialize && data)
         memset(data, '\0', size);
 }
 
+void ArrayBufferContents::allocateMemoryOrNull(size_t size, InitializationPolicy policy, void*& data)
+{
+    if (s_adjustAmountOfExternalAllocatedMemoryFunction)
+        s_adjustAmountOfExternalAllocatedMemoryFunction(static_cast<int>(size));
+    data = partitionAllocGenericFlags(WTF::Partitions::bufferPartition(), PartitionAllocReturnNull, size, WTF_HEAP_PROFILER_TYPE_NAME(ArrayBufferContents));
+    if (policy == ZeroInitialize && data)
+        memset(data, '\0', size);
+}

[Dan Ehrenberg, 2016/01/13 22:55:14]

Any way you could reduce the duplication here with the above method, for example
make it take flags as an argument?

[caitp (gmail), 2016/01/13 23:41:10]

done

+
 void ArrayBufferContents::freeMemory(void* data, size_t size)
 {
     Partitions::bufferFree(data);
     if (s_adjustAmountOfExternalAllocatedMemoryFunction)
         s_adjustAmountOfExternalAllocatedMemoryFunction(-static_cast<int>(size));
 }
 
 ArrayBufferContents::DataHolder::DataHolder()
     : m_data(nullptr)
     , m_sizeInBytes(0)
@@ skipping 31 matching lines @@
     ASSERT(!other.m_sizeInBytes);
     ArrayBufferContents::freeMemory(other.m_data, other.m_sizeInBytes);
     ArrayBufferContents::allocateMemory(m_sizeInBytes, DontInitialize, other.m_data);
     if (!other.m_data)
         return;
     memcpy(other.m_data, m_data, m_sizeInBytes);
     other.m_sizeInBytes = m_sizeInBytes;
 }
 
 } // namespace WTF