Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1577783003: Revert of Add a origin clean flag in ImageBitmap class (Closed)

Created:
4 years, 11 months ago by Marc Treib
Modified:
4 years, 11 months ago
CC:
chromium-reviews, philipj_slow, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a origin clean flag in ImageBitmap class (patchset #14 id:260001 of https://codereview.chromium.org/1532473002/ ) Reason for revert: Seems to have broken Oilpan builds: https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac%20Oilpan&number=28566 https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Linux%20Oilpan%20Builder&number=100 Original issue's description: > Add a origin clean flag in ImageBitmap class > > This CL adds a origin clean flag, such that in the case when the source > of the ImageBitmap contains cross-origin content, we can simply set this > flag instead of reject the promise. > > BUG=569779 > > Committed: https://crrev.com/10b9b4435e25fb8ede2122482426ae81c7980630 > Cr-Commit-Position: refs/heads/master@{#368595} TBR=junov@chromium.org,xidachen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569779 Committed: https://crrev.com/f211b743e659391cf5b674dfe2ea29f6b0fe2b29 Cr-Commit-Position: refs/heads/master@{#368598}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Marc Treib
Created Revert of Add a origin clean flag in ImageBitmap class
4 years, 11 months ago (2016-01-11 16:19:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577783003/1
4 years, 11 months ago (2016-01-11 16:19:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 16:20:28 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 16:21:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f211b743e659391cf5b674dfe2ea29f6b0fe2b29
Cr-Commit-Position: refs/heads/master@{#368598}

Powered by Google App Engine
This is Rietveld 408576698