scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json - Issue 1577773002: WebRTC: Enable OpenH264 for WebRTC standalone bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json

Issue 1577773002: WebRTC: Enable OpenH264 for WebRTC standalone bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Set the GN arguments properly Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium/config.py ('K') | « scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_dbg.json ('k') | scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json

diff --git a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json

index 0bbff71f4072d8681477bdd5353eafecc7df7f54..ea88ad016e31f365da8e8f2e7b8cc009fb4d1110 100644

--- a/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json

+++ b/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_gn_rel.json

@@ -83,7 +83,7 @@

"cwd": "[SLAVE_BUILD]",

"env": {

"GYP_CHROMIUM_NO_ACTION": "1",

- "GYP_DEFINES": "clang=1 component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=x64 use_goma=1"

+ "GYP_DEFINES": "clang=1 component=static_library dcheck_always_on=1 fastbuild=1 ffmpeg_branding=Chrome gomadir='[BUILD]/goma' target_arch=x64 use_goma=1 use_openh264=1 use_third_party_h264=1"

"name": "gclient runhooks"

@@ -95,7 +95,7 @@

"--root=[SLAVE_BUILD]/src",

"gen",

"//out/Release",

- "--args=is_debug=false target_cpu=\"x64\" use_goma=true goma_dir=\"[BUILD]/goma\""

+ "--args=ffmpeg_branding=\"Chrome\" use_openh264=true use_third_party_h264=true is_debug=false target_cpu=\"x64\" use_goma=true goma_dir=\"[BUILD]/goma\""

"cwd": "[SLAVE_BUILD]",

"name": "gn"