Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 157773002: rebaseline_server: properly handle unexpected GETs (Closed)

Created:
6 years, 10 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: properly handle unexpected GETs BUG=skia:2147 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -45 lines) Patch
M gm/rebaseline_server/server.py View 3 chunks +51 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Ready for review. Ravi, please try http://172.24.179.183:9999/ from the same browser that has been failing, ...
6 years, 10 months ago (2014-02-07 18:10:31 UTC) #1
rmistry
It works from my browser now. Code: LGTM
6 years, 10 months ago (2014-02-07 18:19:13 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 10 months ago (2014-02-07 18:21:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/157773002/1
6 years, 10 months ago (2014-02-07 18:21:53 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 18:22:01 UTC) #5
Message was sent while issue was closed.
Change committed as 13366

Powered by Google App Engine
This is Rietveld 408576698