Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1577723004: XFA: Fix compilation warnings introduced at b9bc6b7 (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Fix compilation warnings introduced at b9bc6b7 Inconsisten use of "override". BUG=pdfium:359 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3485566b6182ef8b7125784a24a035c4a738d27e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M xfa/src/fgas/src/layout/fx_rtfbreak.h View 1 chunk +32 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Tom Sepez
Quick review. Thanks.
4 years, 11 months ago (2016-01-12 17:08:50 UTC) #3
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-12 18:44:26 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-12 18:51:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3485566b6182ef8b7125784a24a035c4a738d27e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698