Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1577703005: [runtime] Refactor Function object setup into a single place. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Refactor Function object setup into a single place. No need to distribute the setup of the Function global property across three different places, instead do everything in a single place during bootstrapping. R=verwaest@chromium.org Committed: https://crrev.com/243fa1933c17b8fc178d92b2dfbd0390be62a183 Cr-Commit-Position: refs/heads/master@{#33242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -39 lines) Patch
M src/bootstrapper.cc View 2 chunks +25 lines, -30 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-12 15:41:56 UTC) #1
Benedikt Meurer
Hey Toon, Some cleanup after previous refactorings. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-12 15:42:41 UTC) #2
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-12 15:44:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577703005/1
4 years, 11 months ago (2016-01-12 16:03:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 16:43:34 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 16:44:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/243fa1933c17b8fc178d92b2dfbd0390be62a183
Cr-Commit-Position: refs/heads/master@{#33242}

Powered by Google App Engine
This is Rietveld 408576698