chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc - Issue 1577673002: WebRequest API cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc

Issue 1577673002: WebRequest API cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: copy GetSocketAddress().host instead of & to resolve win failure Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h ('k') | chrome/browser/extensions/api/web_request/web_request_api_unittest.cc » ('j') | extensions/browser/api/web_request/web_request_event_details.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc

diff --git a/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc b/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc

index 40ab80151cfc181e581f531899575e641e56d6cb..ec9794a0cc0bb0c2aef6e5e8098361519deb0821 100644

--- a/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc

+++ b/chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc

@@ -11,11 +11,9 @@

#include "extensions/browser/api/activity_log/web_request_constants.h"

#include "extensions/browser/api/web_request/web_request_api.h"

#include "extensions/browser/api/web_request/web_request_api_constants.h"

-#include "extensions/browser/api/web_request/web_request_api_helpers.h"

+#include "extensions/browser/api/web_request/web_request_event_details.h"

#include "net/url_request/url_request.h"

-namespace activitylog = activity_log_web_request_constants;

-namespace helpers = extension_web_request_api_helpers;

namespace keys = extension_web_request_api_constants;

namespace {

@@ -69,7 +67,7 @@ void ChromeExtensionWebRequestEventRouterDelegate::LogExtensionActivity(

void ChromeExtensionWebRequestEventRouterDelegate::ExtractExtraRequestDetails(

const net::URLRequest* request,

- base::DictionaryValue* out) {

+ extensions::WebRequestEventDetails* out) {

int tab_id = -1;

int window_id = -1;

ExtractExtraRequestDetailsInternal(request, &tab_id, &window_id);