Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1577663002: Remove BuilderContext from summary builders. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -172 lines) Patch
M pkg/analyzer/lib/src/summary/base.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 48 chunks +72 lines, -72 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 2 chunks +10 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 29 chunks +40 lines, -49 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summary.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-10 17:36:08 UTC) #1
Paul Berry
lgtm. This will likely conflict with my outstanding CL https://codereview.chromium.org/1576743002/. I'll try to wait for ...
4 years, 11 months ago (2016-01-10 21:58:18 UTC) #2
scheglov
4 years, 11 months ago (2016-01-10 22:03:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e326a505c9f4f6e0e493b9361550a9420f159d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698