[Mac] In +[CustomFrameView load], do not perform any work if the process has a --type flag.

chrome/browser/ui/cocoa/custom_frame_view.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/custom_frame_view.h"
 
+#import <Carbon/Carbon.h>
+#include <crt_externs.h>
 #import <objc/runtime.h>
-#import <Carbon/Carbon.h>
+#include <string.h>
 
 #include "base/logging.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 
 namespace {
 BOOL gCanDrawTitle = NO;
 BOOL gCanGetCornerRadius = NO;
 }  // namespace
 
@@ skipping 17 matching lines @@
 @end
 
 @implementation CustomFrameView
 
 // This is where we swizzle drawRect, and add in two methods that we
 // need. If any of these fail it shouldn't affect the functionality of the
 // others. If they all fail, we will lose window frame theming and
 // roll overs for our close widgets, but things should still function
 // correctly.
 + (void)load {
+  // Swizzling should only happen in the browser process. Interacting with
+  // AppKit will run +[borderViewClass initialize] in the renderer, which
+  // may establish Mach IPC with com.apple.windowserver.
+  // Note that CommandLine has not been initialized yet, since this is running
+  // as a module initializer.
+  const char* const* const argv = *_NSGetArgv();
+  const int argc = *_NSGetArgc();
+  const char kType[] = "--type";

[Mark Mentovai, 2014/02/07 19:58:00]

Missing = relative to what you had before. Put it back!

[Robert Sesek, 2014/02/07 20:08:26]

Done.

+  for (int i = 1; i < argc; ++i) {
+    const char* arg = argv[i];
+    if (strncmp(arg, kType, sizeof(kType) - 1) == 0)

[Mark Mentovai, 2014/02/07 19:58:00]

Tip: strlen(kType) is fine too. The compiler is smart enough to that strlen of a
const char[] is also a compile-time constant. I used to use sizeof-minus-one in
this case because of its obvious compile-time constness, but I’ve switched to
using strlen everywhere: it’s less error-prone because you don’t need to
remember the -1, and if the const char[] turns into some kind of char* (const or
otherwise), the strlen will still be correct, where the sizeof will be incorrect
in the worst possible way, the silent one.

[Robert Sesek, 2014/02/07 20:08:26]

Nice tip. Compiler so smart.

+      return;
+  }
+
   base::mac::ScopedNSAutoreleasePool pool;
 
   // On 10.8+ the background for textured windows are no longer drawn by
   // NSGrayFrame, and NSThemeFrame is used instead <http://crbug.com/114745>.
   Class borderViewClass = NSClassFromString(
       base::mac::IsOSMountainLionOrLater() ? @"NSThemeFrame" : @"NSGrayFrame");
   DCHECK(borderViewClass);
   if (!borderViewClass) return;
 
   // Exchange draw rect.
@@ skipping 73 matching lines @@
   if ([window respondsToSelector:@selector(fullScreenButtonOriginAdjustment)])
     offset = [window fullScreenButtonOriginAdjustment];
 
   NSPoint origin = [self _fullScreenButtonOriginOriginal];
   origin.x += offset.x;
   origin.y += offset.y;
   return origin;
 }
 
 @end