Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1577533002: Add download pings for: .rels, .msg, .eml. Add UMA for .rtf. (Closed)

Created:
4 years, 11 months ago by Nathan Parker
Modified:
4 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add download pings for: .rels, .msg, .eml. Add UMA for .rtf. BUG=575275 Committed: https://crrev.com/262ab529ea86ea47c8e4f34dc37a4cca7fbae028 Cr-Commit-Position: refs/heads/master@{#368800}

Patch Set 1 #

Patch Set 2 : Add types to download_extensions.cc #

Patch Set 3 : reorder #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/browser/download/download_extensions.cc View 1 2 3 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/download_protection_util.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Nathan Parker
Asanka -- When I add these to download_extensions.cc, what settings would keep their behaviour unchanged? ...
4 years, 11 months ago (2016-01-09 01:05:02 UTC) #2
asanka
On 2016/01/09 01:05:02, nparker wrote: > Asanka -- > When I add these to download_extensions.cc, ...
4 years, 11 months ago (2016-01-09 03:48:43 UTC) #3
Nathan Parker
Thanks, Asanka. PTAL. asvitkine: Please review small change to histograms.xml.
4 years, 11 months ago (2016-01-11 22:22:14 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 11 months ago (2016-01-11 22:23:56 UTC) #6
asanka
lgtm
4 years, 11 months ago (2016-01-11 22:53:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577533002/60001
4 years, 11 months ago (2016-01-11 22:59:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/164274) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 11 months ago (2016-01-11 23:48:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577533002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577533002/60001
4 years, 11 months ago (2016-01-12 04:18:08 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-12 05:02:24 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 05:03:28 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/262ab529ea86ea47c8e4f34dc37a4cca7fbae028
Cr-Commit-Position: refs/heads/master@{#368800}

Powered by Google App Engine
This is Rietveld 408576698