Update documentation for clang tool refactoring.

Update documentation for clang tool refactoring.

BUG=none

Committed: https://crrev.com/ce2375ee8262f3b29a89ffe7d297f0e8ef46eb00
Cr-Commit-Position: refs/heads/master@{#368748}

[dcheng, 2016-01-09 00:21:45]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-01-11 21:53:13]

https://codereview.chromium.org/1577483003/diff/1/docs/clang_tool_refactoring.md
File docs/clang_tool_refactoring.md (right):

https://codereview.chromium.org/1577483003/diff/1/docs/clang_tool_refactoring...
docs/clang_tool_refactoring.md:31: For convenience, add
`third_party/llvm-build/Release+Asserts/bin` to `$PATH`.
Using this tool needs this dir to be at the front of $PATH, but you don't want
that generally as that puts a different "clang" at the front.. I think we should
put this as a local path change in the how-to-run parts. wdyt?

https://codereview.chromium.org/1577483003/diff/1/docs/clang_tool_refactoring...
docs/clang_tool_refactoring.md:160: that is to `return 1` from `main()`.
Where is the main() function you refer to?

[dcheng, 2016-01-11 22:52:23]

https://codereview.chromium.org/1577483003/diff/1/docs/clang_tool_refactoring.md
File docs/clang_tool_refactoring.md (right):

https://codereview.chromium.org/1577483003/diff/1/docs/clang_tool_refactoring...
docs/clang_tool_refactoring.md:31: For convenience, add
`third_party/llvm-build/Release+Asserts/bin` to `$PATH`.
On 2016/01/11 at 21:53:13, danakj wrote:
> Using this tool needs this dir to be at the front of $PATH, but you don't want
that generally as that puts a different "clang" at the front.. I think we should
put this as a local path change in the how-to-run parts. wdyt?

This really only affects someone with multiple checkouts pinned at different
clang revisions: the script still builds the pinned llvm revision, and things
will work with goma (though I think this is somewhat goma unfriendly, as it
might spam the goma logs with compiler hash mismatch warnings).

https://codereview.chromium.org/1577483003/diff/1/docs/clang_tool_refactoring...
docs/clang_tool_refactoring.md:160: that is to `return 1` from `main()`.
On 2016/01/11 at 21:53:13, danakj wrote:
> Where is the main() function you refer to?

I've updated this to clarify.

[danakj, 2016-01-12 00:02:38]

LGTM

[dcheng, 2016-01-12 00:05:13]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-01-12 00:06:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1577483003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1577483003/20001

[commit-bot: I haz the power, 2016-01-12 01:09:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-12 01:10:25]

Description was changed from

==========
Update documentation for clang tool refactoring.

BUG=none
==========

to

==========
Update documentation for clang tool refactoring.

BUG=none

Committed: https://crrev.com/ce2375ee8262f3b29a89ffe7d297f0e8ef46eb00
Cr-Commit-Position: refs/heads/master@{#368748}
==========

[commit-bot: I haz the power, 2016-01-12 01:10:26]

Patchset 2 (id:??) landed as
https://crrev.com/ce2375ee8262f3b29a89ffe7d297f0e8ef46eb00
Cr-Commit-Position: refs/heads/master@{#368748}