Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1577453002: Merge to XFA: Clean up misc nits found while fixing bugs. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Clean up misc nits found while fixing bugs. Some bits regressed in commit 338805f. Also merge: IWYU fix after commit c5a8933. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1544963002 . Review URL: https://codereview.chromium.org/1570973002 . (cherry picked from commit c5a8933f260ca1034fde902058442984e55c0f7a) (cherry picked from commit e6bd31873c3dba3f79c5ebbbefed636948629cc9) Committed: https://pdfium.googlesource.com/pdfium/+/1b97664bc5b84c7a2b87cc656f8c6a0476f9b71f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -347 lines) Patch
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 23 chunks +116 lines, -123 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 14 chunks +107 lines, -103 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 6 chunks +5 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 7 chunks +9 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 2 chunks +22 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Lei Zhang
TBR Trivial conflicts in fpdfsdk/include/fsdk_baseform.h and fpdfsdk/src/fsdk_baseform.cpp.
4 years, 11 months ago (2016-01-08 22:23:36 UTC) #3
Tom Sepez
lgtm
4 years, 11 months ago (2016-01-08 22:24:22 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-08 22:24:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b97664bc5b84c7a2b87cc656f8c6a0476f9b71f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698